🏃 Run tests with race detector enabled

Author: alvaroaleman

hack/test-all.sh

@@ -22,8 +22,7 @@ setup_envs
 
 header_text "running go test"
 
-# TODO(directxman12): enable the race detector once the LeaderElector race condition is resolved in client-go
-go test ${MOD_OPT} ./... -parallel 4
+go test -race ${MOD_OPT} ./... -parallel 4
 
 header_text "running coverage"
 

pkg/builder/controller_test.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"fmt"
 	"strings"
+	"sync/atomic"
 
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -214,7 +215,7 @@ var _ = Describe("application", func() {
 			var (
 				deployPrctExecuted     = false
 				replicaSetPrctExecuted = false
-				allPrctExecuted        = 0
+				allPrctExecuted        = int64(0)
 			)
 
 			deployPrct := predicate.Funcs{
@@ -246,7 +247,7 @@ var _ = Describe("application", func() {
 						BeAssignableToTypeOf(&appsv1.ReplicaSet{}),
 					))
 
-					allPrctExecuted++
+					atomic.AddInt64(&allPrctExecuted, 1)
 					return true
 				},
 			}

pkg/cache/informer_cache_unit_test.go

@@ -6,6 +6,7 @@ import (
 
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/client-go/kubernetes/scheme"
 
@@ -59,13 +60,14 @@ var _ = Describe("ip.objectTypeForListObject", func() {
 
 	It("should find the object type of a list with a slice of pointers items field", func() {
 		By("registering the type", func() {
+			ip.Scheme = runtime.NewScheme()
 			err := (&crscheme.Builder{
 				GroupVersion: schema.GroupVersion{Group: itemPointerSliceTypeGroupName, Version: itemPointerSliceTypeVersion},
 			}).
 				Register(
 					&controllertest.UnconventionalListType{},
 					&controllertest.UnconventionalListTypeList{},
-				).AddToScheme(scheme.Scheme)
+				).AddToScheme(ip.Scheme)
 			Expect(err).To(BeNil())
 		})
 

pkg/internal/testing/integration/internal/integration_tests/etcd_integration_test.go

@@ -39,9 +39,7 @@ var _ = Describe("Etcd", func() {
 		}
 
 		Expect(etcd.Start()).To(Succeed())
-		defer func() {
-			Expect(etcd.Stop()).To(Succeed())
-		}()
+		Expect(etcd.Stop()).To(Succeed())
 
 		Expect(stderr.String()).NotTo(BeEmpty())
 	})

pkg/internal/testing/integration/internal/process_test.go

@@ -216,6 +216,7 @@ var _ = Describe("Start method", func() {
 			processState.StartTimeout = 1 * time.Second
 
 			Expect(processState.Start(stdout, stderr)).To(Succeed())
+			Expect(processState.Session).Should(gexec.Exit())
 
 			Expect(stdout.String()).To(Equal("that is stdout\n"))
 			Expect(stderr.String()).To(Equal("this is stderr\ni started\n"))

pkg/manager/manager_test.go

@@ -21,7 +21,9 @@ import (
 	"io/ioutil"
 	"net"
 	"net/http"
+	"os"
 	rt "runtime"
+	"runtime/pprof"
 
 	"github.com/go-logr/logr"
 	. "github.com/onsi/ginkgo"
@@ -198,15 +200,18 @@ var _ = Describe("manger.Manager", func() {
 					return nil
 				}))).To(Succeed())
 
-				By("Expect second manager to lose leader election")
+				m2Stop := make(chan struct{})
+				m2done := make(chan struct{})
 				go func() {
 					defer GinkgoRecover()
-					Expect(m2.Start(stop)).NotTo(HaveOccurred())
-					Consistently(m2.Elected()).ShouldNot(Receive())
+					Expect(m2.Start(m2Stop)).NotTo(HaveOccurred())
+					close(m2done)
 				}()
+				Consistently(m2.Elected()).ShouldNot(Receive())
 
-				By("Expect controller on manager without leader lease never to run")
 				Consistently(c2).ShouldNot(Receive())
+				close(m2Stop)
+				<-m2done
 			})
 
 			It("should return an error if namespace not set and not running in cluster", func() {
@@ -837,19 +842,21 @@ var _ = Describe("manger.Manager", func() {
 		})
 	})
 
-	It("should not leak goroutines when stop", func(done Done) {
+	FIt("should not leak goroutines when stop", func(done Done) {
 		// TODO(directxman12): After closing the proper leaks on watch this must be reduced to 0
 		// The leaks currently come from the event-related code (as in corev1.Event).
 		threshold := 3
 
 		m, err := New(cfg, Options{})
 		Expect(err).NotTo(HaveOccurred())
 		startGoruntime := rt.NumGoroutine()
+		pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
 
 		s := make(chan struct{})
 		close(s)
 		Expect(m.Start(s)).NotTo(HaveOccurred())
 
+		pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
 		Expect(rt.NumGoroutine() - startGoruntime).To(BeNumerically("<=", threshold))
 		close(done)
 	})