add recorder test

Author: lichuqiang

pkg/internal/recorder/recorder_suite_test.go

@@ -0,0 +1,51 @@
+/*
+Copyright 2018 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package recorder_test
+
+import (
+	"testing"
+
+	logf "github.com/kubernetes-sigs/controller-runtime/pkg/runtime/log"
+	"github.com/kubernetes-sigs/controller-runtime/pkg/test"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	"k8s.io/client-go/rest"
+)
+
+func TestRecorder(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecsWithDefaultAndCustomReporters(t, "Recorder Integration Suite", []Reporter{test.NewlineReporter{}})
+}
+
+var testenv *test.Environment
+var cfg *rest.Config
+
+var _ = BeforeSuite(func(done Done) {
+	logf.SetLogger(logf.ZapLogger(false))
+
+	testenv = &test.Environment{}
+
+	var err error
+	cfg, err = testenv.Start()
+	Expect(err).NotTo(HaveOccurred())
+
+	close(done)
+}, 60)
+
+var _ = AfterSuite(func() {
+	testenv.Stop()
+})

pkg/internal/recorder/recorder_test.go

@@ -0,0 +1,51 @@
+/*
+Copyright 2018 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package recorder_test
+
+import (
+	"github.com/kubernetes-sigs/controller-runtime/pkg/internal/recorder"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	"k8s.io/client-go/kubernetes/scheme"
+)
+
+var _ = Describe("recorder", func() {
+	Describe("NewProvider", func() {
+		It("should return a provider instance and a nil error.", func() {
+			provider, err := recorder.NewProvider(cfg, scheme.Scheme)
+			Expect(provider).NotTo(BeNil())
+			Expect(err).NotTo(HaveOccurred())
+		})
+
+		It("should return an error if failed to init clientSet.", func() {
+			// Invalid the config
+			cfg1 := *cfg
+			cfg1.ContentType = "invalid-type"
+			_, err := recorder.NewProvider(&cfg1, scheme.Scheme)
+			Expect(err.Error()).To(ContainSubstring("failed to init clientSet"))
+		})
+	})
+	Describe("GetEventRecorder", func() {
+		It("should return a recorder instance.", func() {
+			provider, err := recorder.NewProvider(cfg, scheme.Scheme)
+			Expect(err).NotTo(HaveOccurred())
+
+			recorder := provider.GetEventRecorderFor("test")
+			Expect(recorder).NotTo(BeNil())
+		})
+	})
+})

pkg/manager/manager_test.go

@@ -23,6 +23,7 @@ import (
 	"github.com/kubernetes-sigs/controller-runtime/pkg/cache/informertest"
 	"github.com/kubernetes-sigs/controller-runtime/pkg/client"
 	"github.com/kubernetes-sigs/controller-runtime/pkg/reconcile"
+	"github.com/kubernetes-sigs/controller-runtime/pkg/recorder"
 	"github.com/kubernetes-sigs/controller-runtime/pkg/runtime/inject"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -81,6 +82,17 @@ var _ = Describe("manger.Manager", func() {
 			Expect(err).To(HaveOccurred())
 			Expect(err.Error()).To(ContainSubstring("expected error"))
 
+			close(done)
+		})
+		It("should return an error it can't create a recorder.Provider", func(done Done) {
+			m, err := New(cfg, Options{
+				newRecorderProvider: func(config *rest.Config, scheme *runtime.Scheme) (recorder.Provider, error) {
+					return nil, fmt.Errorf("expected error")
+				}})
+			Expect(m).To(BeNil())
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("expected error"))
+
 			close(done)
 		})
 	})
@@ -362,6 +374,12 @@ var _ = Describe("manger.Manager", func() {
 		Expect(ok).To(BeTrue())
 		Expect(m.GetFieldIndexer()).To(Equal(mrg.fieldIndexes))
 	})
+
+	It("should provide a function to get the EventRecorder", func() {
+		m, err := New(cfg, Options{})
+		Expect(err).NotTo(HaveOccurred())
+		Expect(m.GetRecorder("test")).NotTo(BeNil())
+	})
 })
 
 var _ reconcile.Reconcile = &failRec{}
@@ -389,12 +407,12 @@ var _ inject.Config = &injectable{}
 var _ inject.Stoppable = &injectable{}
 
 type injectable struct {
-	scheme func(scheme *runtime.Scheme) error
-	client func(client.Client) error
-	config func(config *rest.Config) error
-	cache  func(cache.Cache) error
-	f      func(inject.Func) error
-	stop   func(<-chan struct{}) error
+	scheme   func(scheme *runtime.Scheme) error
+	client   func(client.Client) error
+	config   func(config *rest.Config) error
+	cache    func(cache.Cache) error
+	f        func(inject.Func) error
+	stop     func(<-chan struct{}) error
 }
 
 func (i *injectable) InjectCache(c cache.Cache) error {
@@ -442,3 +460,4 @@ func (i *injectable) InjectStopChannel(stop <-chan struct{}) error {
 func (i *injectable) Start(<-chan struct{}) error {
 	return nil
 }
+