Skip to content

Commit 67cfb94

Browse files
authored
Merge pull request #621 from kaitoy/improve-dockerfile
Improve Dockerfile template such that copying vendor dir is cached.
2 parents 4228ca5 + 2d9f02a commit 67cfb94

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/scaffold/manager/dockerfile.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ FROM golang:1.10.3 as builder
4141
4242
# Copy in the go src
4343
WORKDIR /go/src/{{ .Repo }}
44-
COPY pkg/ pkg/
4544
COPY cmd/ cmd/
4645
COPY vendor/ vendor/
46+
COPY pkg/ pkg/
4747
4848
# Build
4949
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager {{ .Repo }}/cmd/manager

test/project/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ FROM golang:1.10.3 as builder
33

44
# Copy in the go src
55
WORKDIR /go/src/sigs.k8s.io/kubebuilder/test/project
6-
COPY pkg/ pkg/
76
COPY cmd/ cmd/
87
COPY vendor/ vendor/
8+
COPY pkg/ pkg/
99

1010
# Build
1111
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager sigs.k8s.io/kubebuilder/test/project/cmd/manager

0 commit comments

Comments
 (0)