Skip to content

Commit 6865d0a

Browse files
authored
Merge pull request #73 from anfernee/fix-panic
Fix un-initialized once that causes panic
2 parents 120b59a + cbd8edb commit 6865d0a

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

pkg/admission/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ type CertProvisioner struct {
3737
CertGenerator generator.CertGenerator
3838
CertWriter writer.CertWriter
3939

40-
once *sync.Once
40+
once sync.Once
4141
}
4242

4343
// Sync takes a runtime.Object which is expected to be either a MutatingWebhookConfiguration or

pkg/admission/controller_test.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package admission
2+
3+
import (
4+
"testing"
5+
6+
"k8s.io/api/admissionregistration/v1beta1"
7+
"sigs.k8s.io/controller-runtime/pkg/client/fake"
8+
)
9+
10+
func TestCertProvisionerInit(t *testing.T) {
11+
p := &CertProvisioner{
12+
Client: fake.NewFakeClient(),
13+
}
14+
config := &v1beta1.MutatingWebhookConfiguration{}
15+
16+
err := p.Sync(config)
17+
if err != nil {
18+
t.Fatalf("expect nil; got %q", err)
19+
}
20+
}

0 commit comments

Comments
 (0)