Skip to content

Commit 68e5598

Browse files
author
Mengqi Yu
committed
allow service targetPort to target arbitrary port
1 parent a01de8c commit 68e5598

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

pkg/webhook/bootstrap.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import (
3131
corev1 "k8s.io/api/core/v1"
3232
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3333
"k8s.io/apimachinery/pkg/runtime"
34+
"k8s.io/apimachinery/pkg/util/intstr"
3435
"sigs.k8s.io/controller-runtime/pkg/client"
3536
"sigs.k8s.io/controller-runtime/pkg/client/config"
3637
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
@@ -92,11 +93,6 @@ func (s *Server) setBootstrappingDefault() {
9293
varString := "localhost"
9394
s.Host = &varString
9495
}
95-
// Override the user's setting to use port 443 until
96-
// https://github.com/kubernetes/kubernetes/issues/67468 is resolved.
97-
if s.Service != nil && s.Port != 443 {
98-
s.Port = 443
99-
}
10096

10197
var certWriter writer.CertWriter
10298
var err error
@@ -356,7 +352,9 @@ func (s *Server) service() *corev1.Service {
356352
Selector: s.Service.Selectors,
357353
Ports: []corev1.ServicePort{
358354
{
359-
Port: s.Port,
355+
// When using service, kube-apiserver will send admission request to port 443.
356+
Port: 443,
357+
TargetPort: intstr.IntOrString{Type: intstr.Int, IntVal: s.Port},
360358
},
361359
},
362360
},

0 commit comments

Comments
 (0)