Merge pull request #2212 from zwtop/set_DeleteStateUnknown

k8s-ci-robot · web-flow · commit 69e67afb21ca · 2023-03-01T07:05:18.000-08:00
🐛 Set DeleteStateUnknown when obj is DeletedFinalStateUnknown
diff --git a/pkg/internal/source/event_handler.go b/pkg/internal/source/event_handler.go
@@ -133,6 +133,9 @@ func (e *EventHandler) OnDelete(obj interface{}) {
 			return
 		}
 
+		// Set DeleteStateUnknown to true
+		d.DeleteStateUnknown = true
+
 		// Set obj to the tombstone obj
 		obj = tombstone.Obj
 	}
diff --git a/pkg/internal/source/internal_test.go b/pkg/internal/source/internal_test.go
@@ -269,6 +269,7 @@ var _ = Describe("Internal", func() {
 			funcs.DeleteFunc = func(ctx context.Context, evt event.DeleteEvent, q workqueue.RateLimitingInterface) {
 				defer GinkgoRecover()
 				Expect(evt.Object).To(Equal(pod))
+				Expect(evt.DeleteStateUnknown).Should(BeTrue())
 			}
 
 			instance.OnDelete(tombstone)

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,9 @@ func (e *EventHandler) OnDelete(obj interface{}) {`
`133`	`133`	`return`
`134`	`134`	`}`
`135`	`135`
	`136`	`+ // Set DeleteStateUnknown to true`
	`137`	`+ d.DeleteStateUnknown = true`
	`138`	`+`
`136`	`139`	`// Set obj to the tombstone obj`
`137`	`140`	`obj = tombstone.Obj`
`138`	`141`	`}`
Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,7 @@ var _ = Describe("Internal", func() {`
`269`	`269`	`funcs.DeleteFunc = func(ctx context.Context, evt event.DeleteEvent, q workqueue.RateLimitingInterface) {`
`270`	`270`	`defer GinkgoRecover()`
`271`	`271`	`Expect(evt.Object).To(Equal(pod))`
	`272`	`+ Expect(evt.DeleteStateUnknown).Should(BeTrue())`
`272`	`273`	`}`
`273`	`274`
`274`	`275`	`instance.OnDelete(tombstone)`