Skip to content

Commit 6fd5269

Browse files
authored
Merge pull request #226 from Liujingfang1/refactor
Move the e2e test library and existing projects to test folder
2 parents 84c6356 + edf884a commit 6fd5269

File tree

66 files changed

+48
-37
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+48
-37
lines changed

test.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ function test_crd_validation {
535535
kubebuilder generate
536536
header_text "generating and testing CRD..."
537537
kubebuilder create config --crds --output crd-validation.yaml
538-
diff crd-validation.yaml $kb_orig/test/resource/expected/crd-expected.yaml
538+
diff crd-validation.yaml $kb_orig/test/data/resource/expected/crd-expected.yaml
539539

540540
kubebuilder create config --controller-image myimage:v1 --name myextensionname --output install.yaml
541541
kubebuilder create controller --group got --version v1beta1 --kind House
@@ -568,9 +568,9 @@ function test_vendor_update {
568568
function test_docs {
569569
header_text "building docs"
570570
kubebuilder docs --docs-copyright "Hello" --title "World" --cleanup=false --brodocs=false
571-
diff docs/reference/includes "$kb_orig/test/docs/expected/includes"
572-
diff docs/reference/manifest.json "$kb_orig/test/docs/expected/manifest.json"
573-
diff docs/reference/config.yaml "$kb_orig/test/docs/expected/config.yaml"
571+
diff docs/reference/includes "$kb_orig/test/data/docs/expected/includes"
572+
diff docs/reference/manifest.json "$kb_orig/test/data/docs/expected/manifest.json"
573+
diff docs/reference/config.yaml "$kb_orig/test/data/docs/expected/config.yaml"
574574

575575
header_text "testing doc annotations"
576576
sed -i -e '/type Bee struct/ i \
@@ -579,7 +579,7 @@ function test_docs {
579579
' pkg/apis/insect/v1beta1/bee_types.go
580580

581581
kubebuilder docs --brodocs=false --cleanup=false
582-
diff docs/reference/config.yaml "$kb_orig/test/docs/expected/config-annotated.yaml"
582+
diff docs/reference/config.yaml "$kb_orig/test/data/docs/expected/config-annotated.yaml"
583583
}
584584

585585
function generate_controller {
File renamed without changes.

test/e2e/doc.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/*
2+
Copyright 2018 The Kubernetes Authors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
// The signals package contains e2e tests for kubebuilder
18+
package e2e

samples/memcached-api-server/Dockerfile.controller renamed to test/projects/memcached-api-server/Dockerfile.controller

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ RUN chmod +x $TEST_ASSET_KUBE_APISERVER
1717
RUN chmod +x $TEST_ASSET_KUBECTL
1818

1919
# Copy in the go src
20-
WORKDIR /go/src/github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server
20+
WORKDIR /go/src/github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server
2121
COPY pkg/ pkg/
2222
COPY cmd/ cmd/
2323
COPY vendor/ vendor/
@@ -30,6 +30,6 @@ RUN go test ./pkg/... ./cmd/...
3030
FROM ubuntu:latest
3131
# RUN apk --no-cache add ca-certificates
3232
WORKDIR /root/
33-
COPY --from=builder /go/src/github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/controller-manager .
33+
COPY --from=builder /go/src/github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/controller-manager .
3434
ENTRYPOINT ["./controller-manager"]
3535
CMD ["--install-crds=false"]

samples/memcached-api-server/cmd/controller-manager/main.go renamed to test/projects/memcached-api-server/cmd/controller-manager/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import (
1313
"github.com/kubernetes-sigs/kubebuilder/pkg/signals"
1414
extensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
1515

16-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/inject"
17-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/inject/args"
16+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/inject"
17+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/inject/args"
1818
)
1919

2020
var installCRDs = flag.Bool("install-crds", true, "install the CRDs used by the controller as part of startup")

samples/memcached-api-server/memcached_test.go renamed to test/projects/memcached-api-server/memcached_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"path/filepath"
66
"runtime"
77
"testing"
8-
"github.com/kubernetes-sigs/kubebuilder/samples/internal/test/e2e"
8+
"github.com/kubernetes-sigs/kubebuilder/test/internal/e2e"
99
)
1010

1111
var kubebuilderTest *e2e.KubebuilderTest

samples/memcached-api-server/pkg/apis/doc.go renamed to test/projects/memcached-api-server/pkg/apis/doc.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
2-
3-
41
//
52
// +domain=memcached.example.com
63

samples/memcached-api-server/pkg/apis/myapps/doc.go renamed to test/projects/memcached-api-server/pkg/apis/myapps/doc.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
2-
3-
4-
51
// +k8s:deepcopy-gen=package,register
62
// +groupName=myapps.memcached.example.com
73

samples/memcached-api-server/pkg/apis/myapps/v1alpha1/doc.go renamed to test/projects/memcached-api-server/pkg/apis/myapps/v1alpha1/doc.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
// +k8s:openapi-gen=true
66
// +k8s:deepcopy-gen=package,register
7-
// +k8s:conversion-gen=github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/apis/myapps
7+
// +k8s:conversion-gen=github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/apis/myapps
88
// +k8s:defaulter-gen=TypeMeta
99
// +groupName=myapps.memcached.example.com
10-
package v1alpha1 // import "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/apis/myapps/v1alpha1"
10+
package v1alpha1 // import "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/apis/myapps/v1alpha1"

samples/memcached-api-server/pkg/apis/myapps/v1alpha1/memcached_types_test.go renamed to test/projects/memcached-api-server/pkg/apis/myapps/v1alpha1/memcached_types_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import (
66

77
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
88

9-
. "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/apis/myapps/v1alpha1"
10-
. "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/clientset/versioned/typed/myapps/v1alpha1"
9+
. "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/apis/myapps/v1alpha1"
10+
. "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/clientset/versioned/typed/myapps/v1alpha1"
1111
)
1212

1313
// EDIT THIS FILE!

samples/memcached-api-server/pkg/apis/myapps/v1alpha1/v1alpha1_suite_test.go renamed to test/projects/memcached-api-server/pkg/apis/myapps/v1alpha1/v1alpha1_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import (
88
. "github.com/onsi/gomega"
99
"k8s.io/client-go/rest"
1010

11-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/clientset/versioned"
12-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/inject"
11+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/clientset/versioned"
12+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/inject"
1313
)
1414

1515
var testenv *test.TestEnvironment

samples/memcached-api-server/pkg/controller/memcached/controller.go renamed to test/projects/memcached-api-server/pkg/controller/memcached/controller.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ import (
77
"github.com/kubernetes-sigs/kubebuilder/pkg/controller"
88
"github.com/kubernetes-sigs/kubebuilder/pkg/controller/types"
99

10-
myappsv1alpha1 "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/apis/myapps/v1alpha1"
11-
myappsv1alpha1client "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/clientset/versioned/typed/myapps/v1alpha1"
12-
myappsv1alpha1informer "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/informers/externalversions/myapps/v1alpha1"
13-
myappsv1alpha1lister "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/listers/myapps/v1alpha1"
14-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/inject/args"
10+
myappsv1alpha1 "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/apis/myapps/v1alpha1"
11+
myappsv1alpha1client "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/clientset/versioned/typed/myapps/v1alpha1"
12+
myappsv1alpha1informer "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/informers/externalversions/myapps/v1alpha1"
13+
myappsv1alpha1lister "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/listers/myapps/v1alpha1"
14+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/inject/args"
1515
"github.com/kubernetes-sigs/kubebuilder/pkg/controller/eventhandlers"
1616
appsv1 "k8s.io/api/apps/v1"
1717
"k8s.io/api/core/v1"

samples/memcached-api-server/pkg/controller/memcached/controller_test.go renamed to test/projects/memcached-api-server/pkg/controller/memcached/controller_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import (
77
"github.com/kubernetes-sigs/kubebuilder/pkg/controller/types"
88
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
99

10-
. "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/apis/myapps/v1alpha1"
11-
. "github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/clientset/versioned/typed/myapps/v1alpha1"
10+
. "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/apis/myapps/v1alpha1"
11+
. "github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/clientset/versioned/typed/myapps/v1alpha1"
1212
)
1313

1414
// EDIT THIS FILE!

samples/memcached-api-server/pkg/controller/memcached/memcached_suite_test.go renamed to test/projects/memcached-api-server/pkg/controller/memcached/memcached_suite_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import (
1111
"k8s.io/client-go/kubernetes"
1212
"k8s.io/client-go/rest"
1313

14-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/clientset/versioned"
15-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/inject"
16-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/inject/args"
14+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/clientset/versioned"
15+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/inject"
16+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/inject/args"
1717
)
1818

1919
var (

samples/memcached-api-server/pkg/inject/args/args.go renamed to test/projects/memcached-api-server/pkg/inject/args/args.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import (
66
"github.com/kubernetes-sigs/kubebuilder/pkg/inject/args"
77
"k8s.io/client-go/rest"
88

9-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/clientset/versioned"
10-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/client/informers/externalversions"
9+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/clientset/versioned"
10+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/client/informers/externalversions"
1111
)
1212

1313
// InjectArgs are the arguments need to initialize controllers

samples/memcached-api-server/pkg/inject/inject.go renamed to test/projects/memcached-api-server/pkg/inject/inject.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
injectargs "github.com/kubernetes-sigs/kubebuilder/pkg/inject/args"
55
"github.com/kubernetes-sigs/kubebuilder/pkg/inject/run"
66

7-
"github.com/kubernetes-sigs/kubebuilder/samples/memcached-api-server/pkg/inject/args"
7+
"github.com/kubernetes-sigs/kubebuilder/test/projects/memcached-api-server/pkg/inject/args"
88
)
99

1010
var (

test_existing_projects.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
go test -v ./samples/memcached-api-server
17+
go test -v ./test/projects/memcached-api-server

0 commit comments

Comments
 (0)