Fix builders WithLogger method

databus23 · databus23 · commit 783114695768 · 2020-09-16T13:33:42.000+02:00
Signed-off-by: Fabian Ruff &lt;fabian.ruff@sap.com&gt;
diff --git a/pkg/builder/controller.go b/pkg/builder/controller.go
@@ -47,7 +47,6 @@ type Builder struct {
 	config           *rest.Config
 	ctrl             controller.Controller
 	ctrlOptions      controller.Options
-	log              logr.Logger
 	name             string
 }
 
@@ -132,7 +131,7 @@ func (blder *Builder) WithOptions(options controller.Options) *Builder {
 
 // WithLogger overrides the controller options's logger used.
 func (blder *Builder) WithLogger(log logr.Logger) *Builder {
-	blder.log = log
+	blder.ctrlOptions.Log = log
 	return blder
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ type Builder struct {`
`47`	`47`	`config *rest.Config`
`48`	`48`	`ctrl controller.Controller`
`49`	`49`	`ctrlOptions controller.Options`
`50`		`- log logr.Logger`
`51`	`50`	`name string`
`52`	`51`	`}`
`53`	`52`
`@@ -132,7 +131,7 @@ func (blder Builder) WithOptions(options controller.Options) Builder {`
`132`	`131`
`133`	`132`	`// WithLogger overrides the controller options's logger used.`
`134`	`133`	`func (blder Builder) WithLogger(log logr.Logger) Builder {`
`135`		`- blder.log = log`
	`134`	`+ blder.ctrlOptions.Log = log`
`136`	`135`	`return blder`
`137`	`136`	`}`
`138`	`137`