Adding unit test cases

Author: bharathi-tenneti

pkg/log/zap/zap_test.go

@@ -26,6 +26,7 @@ import (
 	"github.com/go-logr/logr"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
+	"go.uber.org/zap/zapcore"
 	kapi "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/types"
@@ -364,9 +365,11 @@ var _ = Describe("Zap log level flag options setup", func() {
 			Expect(string(outRaw)).Should(ContainSubstring("info text"))
 			Expect(string(outRaw)).Should(ContainSubstring("debug 1 text"))
 		})
+	})
 
-		It("Should set stacktrace zap-stacktrace-level flags.", func() {
-			args := []string{"--zap-stacktrace-level=disabled"}
+	Context("with  zap-log-level  with increased verbosity.", func() {
+		It("Should set Level 2 increased verbosity for zap-log-level flags.", func() {
+			args := []string{"--zap-log-level=2"}
 			fromFlags.BindFlags(&fs)
 			if err := fs.Parse(args); err != nil {
 				Expect(err).ToNot(HaveOccurred())
@@ -376,31 +379,55 @@ var _ = Describe("Zap log level flag options setup", func() {
 			logger := New(UseFlagOptions(&fromFlags), WriteTo(logOut))
 			logger.V(0).Info("info text")
 			logger.V(1).Info("debug 1 text")
+			logger.V(2).Info("debug 2 text")
 
 			outRaw := logOut.Bytes()
 
-			Expect(outRaw).To(BeEmpty())
+			Expect(string(outRaw)).Should(ContainSubstring("info text"))
+			Expect(string(outRaw)).Should(ContainSubstring("debug 1 text"))
+			Expect(string(outRaw)).Should(ContainSubstring("debug 2 text"))
+
 		})
 
-		It("Should set Level 2 increased verbosity for zap-log-level flags.", func() {
-			args := []string{"--zap-log-level=2"}
+	})
+
+	Context("with  zap-stacktrace-level options provided", func() {
+
+		It("Should set info stacktrace for zap-stacktrace-level flags.", func() {
+			args := []string{"--zap-stacktrace-level=info", "--zap-devel=true"}
 			fromFlags.BindFlags(&fs)
 			if err := fs.Parse(args); err != nil {
 				Expect(err).ToNot(HaveOccurred())
 			}
-			logOut := new(bytes.Buffer)
+			out := Options{}
+			UseFlagOptions(&fromFlags)(&out)
 
-			logger := New(UseFlagOptions(&fromFlags), WriteTo(logOut))
-			logger.V(0).Info("info text")
-			logger.V(1).Info("debug 1 text")
-			logger.V(2).Info("debug 2 text")
+			Expect(out.StacktraceLevel.Enabled(zapcore.InfoLevel)).To(BeTrue())
+		})
 
-			outRaw := logOut.Bytes()
+		It("Should set error stacktrace  for zap-stacktrace-level flags.", func() {
+			args := []string{"--zap-stacktrace-level=error", "--zap-devel=true"}
+			fromFlags.BindFlags(&fs)
+			if err := fs.Parse(args); err != nil {
+				Expect(err).ToNot(HaveOccurred())
+			}
+			out := Options{}
+			UseFlagOptions(&fromFlags)(&out)
 
-			Expect(string(outRaw)).Should(ContainSubstring("info text"))
-			Expect(string(outRaw)).Should(ContainSubstring("debug 1 text"))
-			Expect(string(outRaw)).Should(ContainSubstring("debug 2 text"))
+			Expect(out.StacktraceLevel.Enabled(zapcore.ErrorLevel)).To(BeTrue())
+		})
+
+		It("Should disable stacktrace for zap-stacktrace-level flags.", func() {
+			args := []string{"--zap-stacktrace-level=disabled", "--zap-devel=true"}
+			fromFlags.BindFlags(&fs)
+			if err := fs.Parse(args); err != nil {
+				Expect(err).ToNot(HaveOccurred())
+			}
+			out := Options{}
+			UseFlagOptions(&fromFlags)(&out)
 
+			Expect(out.StacktraceLevel.Enabled(zapcore.FatalLevel)).To(BeTrue())
 		})
 	})
+
 })