Skip to content

Commit 7b28fd8

Browse files
committed
fixup! add new cache.Options field to customize transform
attempt to fix race introduced in test by not referring to modified variable within callback
1 parent 42167fb commit 7b28fd8

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/cache/cache_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,13 +167,14 @@ var _ = Describe("Cache with transformers", func() {
167167
})
168168

169169
BeforeEach(func() {
170-
transformerHits = make(chan struct{}, 10)
170+
hitsChan := make(chan struct{}, 10)
171171

172172
var err error
173173
var transform = func(i interface{}) (interface{}, error) {
174-
transformerHits <- struct{}{}
174+
hitsChan <- struct{}{}
175175
return i, nil
176176
}
177+
transformerHits = hitsChan
177178

178179
clien, err = client.New(cfg, client.Options{})
179180
Expect(err).NotTo(HaveOccurred())

0 commit comments

Comments
 (0)