Added newTimeEncoder() func

Author: bharathi-tenneti

hack/tools/go.sum

@@ -307,6 +307,7 @@ golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACk
 golang.org/x/crypto v0.0.0-20190510104115-cbcb75029529/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20191002192127-34f69633bfdc/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
+golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 h1:ObdrDkeb4kJdCP557AjRjq69pTHfNouLtWZG7j9rPN8=
 golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20191002040644-a1355ae1e2c3 h1:n9HxLrNxWWtEb1cA950nuEEj3QnKbtsCJ6KjcgisNUs=

pkg/log/zap/flags.go

@@ -106,7 +106,7 @@ func (ev *timeEncoderFlag) Type() string {
 }
 
 func (ev *timeEncoderFlag) Set(flagValue string) error {
-	val := strings.ToLower(flagValue)
+	/*val := strings.ToLower(flagValue)
 	var timeEnc zapcore.TimeEncoder
 	switch val {
 	case "iso8601", "rfc3339", "rfc3339nano", "millis", "nanos", "epoch":
@@ -116,11 +116,26 @@ func (ev *timeEncoderFlag) Set(flagValue string) error {
 		ev.setFunc(timeEnc)
 	default:
 		return fmt.Errorf("invalid time encoder value \"%s\"", flagValue)
-	}
+	}*/
+	ev.setFunc(newTimeEncoder(flagValue))
 	ev.value = flagValue
 	return nil
 }
 
+func newTimeEncoder(flagValue string) zapcore.TimeEncoder {
+	var encoder zapcore.TimeEncoder
+	val := strings.ToLower(flagValue)
+	switch val {
+	case "iso8601", "rfc3339", "rfc3339nano", "millis", "nanos", "epoch":
+		if err := encoder.UnmarshalText([]byte(val)); err != nil {
+			fmt.Printf("not able to unmarshal time encoder value \"%s\"", val)
+		}
+	default:
+		fmt.Printf("invalid time encoder value \"%s\"", val)
+	}
+	return encoder
+}
+
 func withTimeEncoding(te zapcore.TimeEncoder) encoderConfigFunc {
 	return func(ec *zapcore.EncoderConfig) {
 		ec.EncodeTime = te

pkg/log/zap/zap.go

@@ -31,6 +31,7 @@ import (
 )
 
 var encVal encoderFlag
+var timeEncVal timeEncoderFlag
 
 // New returns a brand new Logger configured with Opts. It
 // uses KubeAwareEncoder which adds Type information and
@@ -100,6 +101,14 @@ func Encoder(encoder zapcore.Encoder) func(o *Options) {
 	}
 }
 
+// TimeEncoder configures how the logger will encode time format.
+// See Options.TimeEncoder
+func TimeEncoder(timeEncoder string) func(o *Options) {
+	return func(o *Options) {
+		o.TimeEncoder = newTimeEncoder(timeEncoder)
+	}
+}
+
 // Level sets the the minimum enabled logging level e.g Debug, Info
 // See Options.Level
 func Level(level *zap.AtomicLevel) func(o *Options) {
@@ -232,7 +241,7 @@ func (o *Options) BindFlags(fs *flag.FlagSet) {
 			"Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)")
 
 	// Set TimeEncoder value
-	var timeEncVal timeEncoderFlag
+	//var timeEncVal timeEncoderFlag
 	timeEncVal.setFunc = func(fromFlag zapcore.TimeEncoder) {
 		o.TimeEncoder = fromFlag
 	}