Copy object before modifying it

JoelSpeed · JoelSpeed · commit 7f16f2b74493 · 2019-04-03T11:47:26.000+01:00
Otherwise you can get races when getting and listing simultaneously
diff --git a/pkg/cache/internal/cache_reader.go b/pkg/cache/internal/cache_reader.go
@@ -125,8 +125,9 @@ func (c *CacheReader) List(_ context.Context, out runtime.Object, opts ...client
 		if !isObj {
 			return fmt.Errorf("cache contained %T, which is not an Object", obj)
 		}
-		obj.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)
-		runtimeObjs = append(runtimeObjs, obj)
+		outObj := obj.DeepCopyObject()
+		outObj.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)
+		runtimeObjs = append(runtimeObjs, outObj)
 	}
 	filteredItems, err := objectutil.FilterWithLabels(runtimeObjs, labelSel)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,9 @@ func (c *CacheReader) List(_ context.Context, out runtime.Object, opts ...client`
`125`	`125`	`if !isObj {`
`126`	`126`	`return fmt.Errorf("cache contained %T, which is not an Object", obj)`
`127`	`127`	`}`
`128`		`- obj.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)`
`129`		`- runtimeObjs = append(runtimeObjs, obj)`
	`128`	`+ outObj := obj.DeepCopyObject()`
	`129`	`+ outObj.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)`
	`130`	`+ runtimeObjs = append(runtimeObjs, outObj)`
`130`	`131`	`}`
`131`	`132`	`filteredItems, err := objectutil.FilterWithLabels(runtimeObjs, labelSel)`
`132`	`133`	`if err != nil {`