Merge pull request #772 from mcristina422/patch-1

k8s-ci-robot · web-flow · commit 7f899c3d44b5 · 2020-01-22T11:54:34.000-08:00
🏃 Remove unused variable from IsConvertible
diff --git a/pkg/webhook/conversion/conversion.go b/pkg/webhook/conversion/conversion.go
@@ -264,10 +264,6 @@ func IsConvertible(scheme *runtime.Scheme, obj runtime.Object) (bool, error) {
 	}
 
 	if len(hubs) == 1 && len(nonSpokes) == 0 { // convertible
-		spokeVersions := []string{}
-		for _, sp := range spokes {
-			spokeVersions = append(spokeVersions, sp.GetObjectKind().GroupVersionKind().String())
-		}
 		return true, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -264,10 +264,6 @@ func IsConvertible(scheme *runtime.Scheme, obj runtime.Object) (bool, error) {`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`if len(hubs) == 1 && len(nonSpokes) == 0 { // convertible`
`267`		`- spokeVersions := []string{}`
`268`		`- for _, sp := range spokes {`
`269`		`- spokeVersions = append(spokeVersions, sp.GetObjectKind().GroupVersionKind().String())`
`270`		`- }`
`271`	`267`	`return true, nil`
`272`	`268`	`}`
`273`	`269`