Lint

Author: JoelSpeed

pkg/leaderelection/doc.go

@@ -17,5 +17,4 @@ limitations under the License.
 /*
 Package leaderelection contains a constructors for a leader election resource lock
 */
-
 package leaderelection

pkg/leaderelection/fake/doc.go

@@ -18,5 +18,4 @@ limitations under the License.
 Package fake mocks a resource lock for testing purposes.
 Always returns leadership.
 */
-
 package fake

pkg/leaderelection/fake/leader_election.go

@@ -28,17 +28,17 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/recorder"
 )
 
-// NewFakeResourceLock creates a new FakeResourceLock for use in testing
+// NewResourceLock creates a new ResourceLock for use in testing
 // leader election.
-func NewFakeResourceLock(config *rest.Config, recorderProvider recorder.Provider, options leaderelection.Options) (resourcelock.Interface, error) {
+func NewResourceLock(config *rest.Config, recorderProvider recorder.Provider, options leaderelection.Options) (resourcelock.Interface, error) {
 	// Leader id, needs to be unique
 	id, err := os.Hostname()
 	if err != nil {
 		return nil, err
 	}
 	id = id + "_" + string(uuid.NewUUID())
 
-	return &FakeResourceLock{
+	return &ResourceLock{
 		id: id,
 		record: resourcelock.LeaderElectionRecord{
 			HolderIdentity:       id,
@@ -50,41 +50,41 @@ func NewFakeResourceLock(config *rest.Config, recorderProvider recorder.Provider
 	}, nil
 }
 
-// FakeResourceLock implements the ResourceLockInterface.
+// ResourceLock implements the ResourceLockInterface.
 // By default returns that the current identity holds the lock.
-type FakeResourceLock struct {
+type ResourceLock struct {
 	id     string
 	record resourcelock.LeaderElectionRecord
 }
 
 // Get implements the ResourceLockInterface.
-func (f *FakeResourceLock) Get() (*resourcelock.LeaderElectionRecord, error) {
+func (f *ResourceLock) Get() (*resourcelock.LeaderElectionRecord, error) {
 	return &f.record, nil
 }
 
 // Create implements the ResourceLockInterface.
-func (f *FakeResourceLock) Create(ler resourcelock.LeaderElectionRecord) error {
+func (f *ResourceLock) Create(ler resourcelock.LeaderElectionRecord) error {
 	f.record = ler
 	return nil
 }
 
 // Update implements the ResourceLockInterface.
-func (f *FakeResourceLock) Update(ler resourcelock.LeaderElectionRecord) error {
+func (f *ResourceLock) Update(ler resourcelock.LeaderElectionRecord) error {
 	f.record = ler
 	return nil
 }
 
 // RecordEvent implements the ResourceLockInterface.
-func (f *FakeResourceLock) RecordEvent(s string) {
+func (f *ResourceLock) RecordEvent(s string) {
 	return
 }
 
-// Idenity implements the ResourceLockInterface.
-func (f *FakeResourceLock) Identity() string {
+// Identity implements the ResourceLockInterface.
+func (f *ResourceLock) Identity() string {
 	return f.id
 }
 
 // Describe implements the ResourceLockInterface.
-func (f *FakeResourceLock) Describe() string {
+func (f *ResourceLock) Describe() string {
 	return f.id
 }

pkg/manager/manager_test.go

@@ -221,7 +221,7 @@ var _ = Describe("manger.Manager", func() {
 				LeaderElection:          true,
 				LeaderElectionID:        "controller-runtime",
 				LeaderElectionNamespace: "default",
-				newResourceLock:         fakeleaderelection.NewFakeResourceLock,
+				newResourceLock:         fakeleaderelection.NewResourceLock,
 			})
 		})
 	})