Skip to content

Commit 8175828

Browse files
committed
pkg/metrics: add 100/1000s buckets for workqueue histograms
Controllers making many external requests in large clusters may have normal operating latency on the order of ~100s. Add buckets that cover the range, allowing metric backends to interpolate percentile estimates properly. Fixes #2625
1 parent 91f642b commit 8175828

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/metrics/workqueue.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ var (
5454
Subsystem: WorkQueueSubsystem,
5555
Name: QueueLatencyKey,
5656
Help: "How long in seconds an item stays in workqueue before being requested",
57-
Buckets: prometheus.ExponentialBuckets(10e-9, 10, 10),
57+
Buckets: prometheus.ExponentialBuckets(10e-9, 10, 12),
5858
}, []string{"name"})
5959

6060
workDuration = prometheus.NewHistogramVec(prometheus.HistogramOpts{
6161
Subsystem: WorkQueueSubsystem,
6262
Name: WorkDurationKey,
6363
Help: "How long in seconds processing an item from workqueue takes.",
64-
Buckets: prometheus.ExponentialBuckets(10e-9, 10, 10),
64+
Buckets: prometheus.ExponentialBuckets(10e-9, 10, 12),
6565
}, []string{"name"})
6666

6767
unfinished = prometheus.NewGaugeVec(prometheus.GaugeOpts{

0 commit comments

Comments
 (0)