Merge pull request #19 from pwittrock/coverage

Enforce code coverage in travis

Author: k8s-ci-robot

pkg/event/event_suite_test.go

@@ -172,9 +172,6 @@ var _ = Describe("manger.Manager", func() {
 	})
 
 	Describe("Add", func() {
-		It("should fai if there is an erorr in SetFields", func() {
-		})
-
 		It("should immediately start the Component if the Manager has already Started another Component",
 			func(done Done) {
 				m, err := New(cfg, Options{})
@@ -235,6 +232,12 @@ var _ = Describe("manger.Manager", func() {
 
 			close(done)
 		})
+
+		It("should fail if SetFields fails", func() {
+			m, err := New(cfg, Options{})
+			Expect(err).NotTo(HaveOccurred())
+			Expect(m.Add(&failRec{})).To(HaveOccurred())
+		})
 	})
 	Describe("SetFields", func() {
 		It("should inject field values", func(done Done) {
@@ -358,6 +361,10 @@ func (*failRec) Reconcile(reconcile.Request) (reconcile.Result, error) {
 	return reconcile.Result{}, nil
 }
 
+func (*failRec) Start(<-chan struct{}) error {
+	return nil
+}
+
 func (*failRec) InjectClient(client.Client) error {
 	return fmt.Errorf("expected error")
 }

pkg/event/event_test.go

@@ -139,8 +139,20 @@ gometalinter.v2 --disable-all \
 
 header_text "running go test"
 
-go test ./pkg/...
+go test ./pkg/... -parallel 4
 
 header_text "running go install"
 
 go install ./example
+
+header_text "running coverage"
+
+# Verify no coverage regressions have been introduced.  Remove the exception list from here
+# once the coverage has been brought back up
+if [[ ! $(go test ./pkg/...  -coverprofile cover.out -parallel 4 | grep -v "100" | grep -v "no test files" | grep -v "github.com/kubernetes-sigs/controller-runtime/pkg/admission/certprovisioner" | grep -v "github.com/kubernetes-sigs/controller-runtime/pkg/internal/admission" | grep -v "github.com/kubernetes-sigs/controller-runtime/pkg/cache" | grep -v "github.com/kubernetes-sigs/controller-runtime/pkg/client" | grep -v "github.com/kubernetes-sigs/controller-runtime/pkg/event") ]]; then
+echo "ok"
+else
+echo "missing test coverage"
+exit 1
+fi
+