Skip to content

Commit 8a26689

Browse files
committed
Change default webhook port to 9443
1 parent e50c7b8 commit 8a26689

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

pkg/builder/builder_suite_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ var _ = AfterSuite(func() {
7373
metrics.DefaultBindAddress = ":8080"
7474

7575
// Change the webhook.DefaultPort back to the original default.
76-
webhook.DefaultPort = 443
76+
webhook.DefaultPort = 9443
7777
})
7878

7979
func addCRDToEnvironment(env *envtest.Environment, gvks ...schema.GroupVersionKind) {

pkg/manager/manager_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,14 @@ var _ = Describe("manger.Manager", func() {
133133

134134
It("should lazily initialize a webhook server if needed", func(done Done) {
135135
By("creating a manager with options")
136-
m, err := New(cfg, Options{Port: 9443, Host: "foo.com"})
136+
m, err := New(cfg, Options{Port: 9440, Host: "foo.com"})
137137
Expect(err).NotTo(HaveOccurred())
138138
Expect(m).NotTo(BeNil())
139139

140140
By("checking options are passed to the webhook server")
141141
svr := m.GetWebhookServer()
142142
Expect(svr).NotTo(BeNil())
143-
Expect(svr.Port).To(Equal(9443))
143+
Expect(svr.Port).To(Equal(9440))
144144
Expect(svr.Host).To(Equal("foo.com"))
145145

146146
close(done)

pkg/webhook/server.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import (
3737
)
3838

3939
// DefaultPort is the default port that the webhook server serves.
40-
var DefaultPort = 443
40+
var DefaultPort = 9443
4141

4242
// Server is an admission webhook server that can serve traffic and
4343
// generates related k8s resources for deploying.
@@ -47,7 +47,7 @@ type Server struct {
4747
Host string
4848

4949
// Port is the port number that the server will serve.
50-
// It will be defaulted to 443 if unspecified.
50+
// It will be defaulted to 9443 if unspecified.
5151
Port int
5252

5353
// CertDir is the directory that contains the server key and certificate. The

0 commit comments

Comments
 (0)