Skip to content

Commit 949bafe

Browse files
author
Mengqi Yu
committed
add tests for fs cert writer
1 parent 80ceca2 commit 949bafe

File tree

3 files changed

+369
-10
lines changed

3 files changed

+369
-10
lines changed

pkg/admission/cert/writer/certwriter_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ var _ = Describe("NewProvider", func() {
5757
Client: cl,
5858
CertGenerator: &generator.SelfSignedCertGenerator{},
5959
},
60-
//&FSCertWriter{
61-
// CertGenerator: &certgenerator.SelfSignedCertGenerator{},
62-
//},
60+
&FSCertWriter{
61+
CertGenerator: &generator.SelfSignedCertGenerator{},
62+
},
6363
},
6464
}
6565
close(done)
@@ -188,7 +188,7 @@ var _ = Describe("handleCommon", func() {
188188
certrw := &fakeCertReadWriter{
189189
readCertAndErr: []certAndErr{
190190
{
191-
err: errors.NewNotFound(schema.GroupResource{}, "foo"),
191+
err: notFoundError{errors.NewNotFound(schema.GroupResource{}, "foo")},
192192
cert: cert,
193193
},
194194
},
@@ -204,7 +204,7 @@ var _ = Describe("handleCommon", func() {
204204
certrw := &fakeCertReadWriter{
205205
readCertAndErr: []certAndErr{
206206
{
207-
err: errors.NewNotFound(schema.GroupResource{}, "foo"),
207+
err: notFoundError{errors.NewNotFound(schema.GroupResource{}, "foo")},
208208
},
209209
},
210210
writeCertAndErr: []certAndErr{
@@ -318,15 +318,15 @@ var _ = Describe("handleCommon", func() {
318318
certrw := &fakeCertReadWriter{
319319
readCertAndErr: []certAndErr{
320320
{
321-
err: errors.NewNotFound(schema.GroupResource{}, "foo"),
321+
err: notFoundError{errors.NewNotFound(schema.GroupResource{}, "foo")},
322322
},
323323
{
324324
cert: cert,
325325
},
326326
},
327327
writeCertAndErr: []certAndErr{
328328
{
329-
err: errors.NewAlreadyExists(schema.GroupResource{}, "foo"),
329+
err: alreadyExistError{errors.NewAlreadyExists(schema.GroupResource{}, "foo")},
330330
},
331331
},
332332
}
@@ -341,15 +341,15 @@ var _ = Describe("handleCommon", func() {
341341
certrw := &fakeCertReadWriter{
342342
readCertAndErr: []certAndErr{
343343
{
344-
err: errors.NewNotFound(schema.GroupResource{}, "foo"),
344+
err: notFoundError{errors.NewNotFound(schema.GroupResource{}, "foo")},
345345
},
346346
{
347347
err: goerrors.New("failed to read"),
348348
},
349349
},
350350
writeCertAndErr: []certAndErr{
351351
{
352-
err: errors.NewAlreadyExists(schema.GroupResource{}, "foo"),
352+
err: alreadyExistError{errors.NewAlreadyExists(schema.GroupResource{}, "foo")},
353353
},
354354
},
355355
}

0 commit comments

Comments
 (0)