Skip to content

Commit 95ace23

Browse files
committed
fix golint
1 parent b74d08e commit 95ace23

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

pkg/internal/controller/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ var _ inject.Recorder = &Controller{}
245245

246246
// InjectRecorder is internal should be called only by the Controller.
247247
// InjectRecorder is used to inject the event recorder.
248-
func (c *Controller) InjectRecorder(provider recorder.RecorderProvider) error {
248+
func (c *Controller) InjectRecorder(provider recorder.Provider) error {
249249
if c.recorder != nil {
250250
return nil
251251
}

pkg/manager/internal.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ type controllerManager struct {
5353

5454
// recorderProvider is used to generate event recorders that will be injected into Controllers
5555
// (and EventHandlers, Sources and Predicates).
56-
recorderProvider recorder.RecorderProvider
56+
recorderProvider recorder.Provider
5757

5858
mu sync.Mutex
5959
started bool

pkg/manager/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ func New(config *rest.Config, options Options) (Manager, error) {
134134
cm.fieldIndexes = cm.cache
135135
cm.client = client.DelegatingClient{ReadInterface: cm.cache, WriteInterface: writeObj}
136136

137-
cm.recorderProvider = recorder.NewRecorderProvider()
137+
cm.recorderProvider = recorder.NewProvider()
138138
cm.recorderProvider.SetScheme(cm.scheme)
139139
cm.recorderProvider.SetClientSet(clientconfig.GetKubernetesClientSetOrDie())
140140
return cm, nil

pkg/recorder/recorder.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ import (
2727
"k8s.io/client-go/tools/record"
2828
)
2929

30-
// RecorderProvider knows how to generate new event recorders with given name.
31-
type RecorderProvider interface {
30+
// Provider knows how to generate new event recorders with given name.
31+
type Provider interface {
3232
// NewRecorder returns an EventRecorder with given name.
3333
GetEventRecorderFor(name string) (record.EventRecorder, error)
3434
// SetClientSet specifies the Clientset of the provider.
@@ -37,30 +37,30 @@ type RecorderProvider interface {
3737
SetScheme(scheme *runtime.Scheme)
3838
}
3939

40-
type recorderProvider struct {
40+
type provider struct {
4141
clientSet *kubernetes.Clientset
4242
scheme *runtime.Scheme
4343
eventBroadcaster record.EventBroadcaster
4444
}
4545

46-
// NewRecorderProvider create a new RecorderProvider instance.
47-
func NewRecorderProvider() RecorderProvider {
48-
return &recorderProvider{}
46+
// NewProvider create a new Provider instance.
47+
func NewProvider() Provider {
48+
return &provider{}
4949
}
5050

51-
func (p *recorderProvider) SetClientSet(cs *kubernetes.Clientset) {
51+
func (p *provider) SetClientSet(cs *kubernetes.Clientset) {
5252
if p.clientSet == nil {
5353
p.clientSet = cs
5454
}
5555
}
5656

57-
func (p *recorderProvider) SetScheme(scheme *runtime.Scheme) {
57+
func (p *provider) SetScheme(scheme *runtime.Scheme) {
5858
if p.scheme == nil {
5959
p.scheme = scheme
6060
}
6161
}
6262

63-
func (p *recorderProvider) GetEventRecorderFor(name string) (record.EventRecorder, error) {
63+
func (p *provider) GetEventRecorderFor(name string) (record.EventRecorder, error) {
6464
if p.scheme == nil {
6565
return nil, fmt.Errorf("must call SetScheme to specify Scheme before getting recorder")
6666
}

pkg/runtime/inject/inject.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@ func StopChannelInto(stop <-chan struct{}, i interface{}) (bool, error) {
102102
// Recorder is used by the ControllerManager to inject recorder into Sources, EventHandlers, Predicates, and
103103
// Reconciles
104104
type Recorder interface {
105-
InjectRecorder(provider recorder.RecorderProvider) error
105+
InjectRecorder(provider recorder.Provider) error
106106
}
107107

108108
// RecorderInto will set recorder and return the result on i if it implements Recorder. Returns
109109
// false if i does not implement Recorder.
110-
func RecorderInto(provider recorder.RecorderProvider, i interface{}) (bool, error) {
110+
func RecorderInto(provider recorder.Provider, i interface{}) (bool, error) {
111111
if is, ok := i.(Recorder); ok {
112112
return true, is.InjectRecorder(provider)
113113
}

0 commit comments

Comments
 (0)