Skip to content

Commit 9ce51b8

Browse files
committed
Fleet example changes
Signed-off-by: Iván Álvarez <[email protected]>
1 parent 56e0c2b commit 9ce51b8

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

examples/fleet/main.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,9 @@ func main() {
6868
// Setup a Manager, note that this not yet engages clusters, only makes them available.
6969
entryLog.Info("Setting up manager")
7070
provider := &KindClusterProvider{
71-
log: log.Log.WithName("kind-cluster-provider"),
72-
clusters: map[string]cluster.Cluster{},
71+
log: log.Log.WithName("kind-cluster-provider"),
72+
clusters: map[string]cluster.Cluster{},
73+
cancelFns: map[string]context.CancelFunc{},
7374
}
7475
mgr, err := manager.New(
7576
cfg,
@@ -85,18 +86,18 @@ func main() {
8586
func(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
8687
log := log.FromContext(ctx)
8788

88-
cluster, err := mgr.GetCluster(ctx, req.ClusterName)
89+
cl, err := mgr.GetCluster(ctx, req.ClusterName)
8990
if err != nil {
9091
return reconcile.Result{}, err
9192
}
92-
client := cluster.GetClient()
93+
client := cl.GetClient()
9394

9495
// Retrieve the pod from the cluster.
9596
pod := &corev1.Pod{}
9697
if err := client.Get(ctx, req.NamespacedName, pod); err != nil {
9798
return reconcile.Result{}, err
9899
}
99-
log.Info("Reconciling pod", "name", pod.Name, "uuid", pod.UID)
100+
log.Info(fmt.Sprintf("Retrieved pod %s:>%s/%s", cl.Name(), pod.Namespace, pod.Name))
100101

101102
// Print any annotations that start with fleet.
102103
for k, v := range pod.Labels {
@@ -185,7 +186,10 @@ func (k *KindClusterProvider) Run(ctx context.Context, mgr manager.Manager) erro
185186
k.log.Info("failed to create rest config", "error", err)
186187
return false, nil // keep going
187188
}
188-
cl, err := cluster.New(cfg, k.Options...)
189+
// Copy provider options and append the cluster name
190+
clOptions := append(k.Options, cluster.WithName(clusterName))
191+
192+
cl, err := cluster.New(cfg, clOptions...)
189193
if err != nil {
190194
k.log.Info("failed to create cluster", "error", err)
191195
return false, nil // keep going

pkg/manager/internal.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,9 +619,9 @@ func (cm *controllerManager) Engage(ctx context.Context, cl cluster.Cluster) err
619619
// be reentrant via noop
620620
cm.engagedClustersLock.RLock()
621621
if _, ok := cm.engagedClusters[cl.Name()]; ok {
622-
cm.engagedClustersLock.RUnlock()
623622
return nil
624623
}
624+
cm.engagedClustersLock.RUnlock()
625625

626626
// add early because any engaged runnable could access it
627627
cm.engagedClustersLock.Lock()

0 commit comments

Comments
 (0)