Verify informers have started before waiting to sync.

Author: pwittrock

pkg/cache/cache.go

@@ -81,9 +81,14 @@ func (o *objectCache) init(obj runtime.Object) error {
 	if err != nil {
 		return err
 	}
-	log.Info("Waiting to sync cache for type.", "Type", fmt.Sprintf("%T", obj))
-	toolscache.WaitForCacheSync(o.informers.stop, i.HasSynced)
-	log.Info("Finished to syncing cache for type.", "Type", fmt.Sprintf("%T", obj))
+	if o.informers.started {
+		log.Info("Waiting to sync cache for type.", "Type", fmt.Sprintf("%T", obj))
+		toolscache.WaitForCacheSync(o.informers.stop, i.HasSynced)
+		log.Info("Finished to syncing cache for type.", "Type", fmt.Sprintf("%T", obj))
+	} else {
+		return fmt.Errorf("must start Cache before calling Get or List %s %s",
+			"Object", fmt.Sprintf("%T", obj))
+	}
 	return nil
 }
 

pkg/source/source.go

@@ -26,6 +26,8 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/util/workqueue"
 
+	"sync"
+
 	"github.com/kubernetes-sigs/controller-runtime/pkg/cache"
 	"github.com/kubernetes-sigs/controller-runtime/pkg/predicate"
 )
@@ -67,6 +69,8 @@ type Kind struct {
 
 	// cache used to watch APIs
 	cache cache.Cache
+
+	once sync.Once
 }
 
 var _ Source = &Kind{}