Address PR Review

acumino · acumino · commit af8151f6a0a8 · 2022-03-02T21:53:06.000+05:30
diff --git a/go.mod b/go.mod
@@ -7,7 +7,6 @@ require (
 	github.com/fsnotify/fsnotify v1.5.1
 	github.com/go-logr/logr v1.2.0
 	github.com/go-logr/zapr v1.2.0
-	github.com/onsi/ginkgo v1.16.5
 	github.com/onsi/ginkgo/v2 v2.1.1
 	github.com/onsi/gomega v1.17.0
 	github.com/prometheus/client_golang v1.11.1
@@ -43,6 +42,7 @@ require (
 	github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
+	github.com/onsi/ginkgo v1.16.5 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/prometheus/common v0.28.0 // indirect
 	github.com/prometheus/procfs v0.6.0 // indirect
diff --git a/pkg/builder/builder_suite_test.go b/pkg/builder/builder_suite_test.go
@@ -37,7 +37,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
 )
 
-var suiteName = "application Suite"
+const suiteName = "application Suite"
 
 func TestBuilder(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/cache/cache_suite_test.go b/pkg/cache/cache_suite_test.go
@@ -30,7 +30,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Cache Suite"
+const suiteName = "Cache Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/cache/internal/internal_suite_test.go b/pkg/cache/internal/internal_suite_test.go
@@ -25,7 +25,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Cache Internal Suite"
+const suiteName = "Cache Internal Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/client/apiutil/apiutil_suite_test.go b/pkg/client/apiutil/apiutil_suite_test.go
@@ -29,7 +29,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "API Utilities Test Suite"
+const suiteName = "API Utilities Test Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/client/client_suite_test.go b/pkg/client/client_suite_test.go
@@ -33,7 +33,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Client Suite"
+const suiteName = "Client Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/client/config/config_suite_test.go b/pkg/client/config/config_suite_test.go
@@ -28,7 +28,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Client Config Test Suite"
+const suiteName = "Client Config Test Suite"
 
 func TestConfig(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/client/fake/client_suite_test.go b/pkg/client/fake/client_suite_test.go
@@ -28,7 +28,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Fake client Suite"
+const suiteName = "Fake client Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/cluster/cluster_suite_test.go b/pkg/cluster/cluster_suite_test.go
@@ -31,7 +31,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Cluster Suite"
+const suiteName = "Cluster Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/config/config_suite_test.go b/pkg/config/config_suite_test.go
@@ -26,7 +26,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Config Suite"
+const suiteName = "Config Suite"
 
 func TestScheme(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/controller/controller_suite_test.go b/pkg/controller/controller_suite_test.go
@@ -37,7 +37,7 @@ import (
 	crscheme "sigs.k8s.io/controller-runtime/pkg/scheme"
 )
 
-var suiteName = "Controller Integration Suite"
+const suiteName = "Controller Integration Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/controller/controllerutil/controllerutil_suite_test.go b/pkg/controller/controllerutil/controllerutil_suite_test.go
@@ -29,7 +29,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Controllerutil Suite"
+const suiteName = "Controllerutil Suite"
 
 func TestControllerutil(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/envtest/envtest_suite_test.go b/pkg/envtest/envtest_suite_test.go
@@ -30,7 +30,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Envtest Suite"
+const suiteName = "Envtest Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/finalizer/finalizer_test.go b/pkg/finalizer/finalizer_test.go
@@ -23,7 +23,7 @@ func (f mockFinalizer) Finalize(context.Context, client.Object) (Result, error)
 	return f.result, f.err
 }
 
-var suiteName = "Finalizer Suite"
+const suiteName = "Finalizer Suite"
 
 func TestFinalizer(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/handler/eventhandler_suite_test.go b/pkg/handler/eventhandler_suite_test.go
@@ -29,7 +29,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Eventhandler Suite"
+const suiteName = "Eventhandler Suite"
 
 func TestEventhandler(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/healthz/healthz_suite_test.go b/pkg/healthz/healthz_suite_test.go
@@ -27,7 +27,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Healthz Suite"
+const suiteName = "Healthz Suite"
 
 func TestHealthz(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/internal/controller/controller_suite_test.go b/pkg/internal/controller/controller_suite_test.go
@@ -30,7 +30,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Controller internal Suite"
+const suiteName = "Controller internal Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/internal/recorder/recorder_suite_test.go b/pkg/internal/recorder/recorder_suite_test.go
@@ -30,7 +30,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Recorder Integration Suite"
+const suiteName = "Recorder Integration Suite"
 
 func TestRecorder(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/internal/testing/addr/addr_suite_test.go b/pkg/internal/testing/addr/addr_suite_test.go
@@ -26,7 +26,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Addr Suite"
+const suiteName = "Addr Suite"
 
 func TestAddr(t *testing.T) {
 	t.Parallel()
diff --git a/pkg/internal/testing/certs/certs_suite_test.go b/pkg/internal/testing/certs/certs_suite_test.go
@@ -26,7 +26,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "TinyCA (Internal Certs) Suite"
+const suiteName = "TinyCA (Internal Certs) Suite"
 
 func TestInternal(t *testing.T) {
 	t.Parallel()
diff --git a/pkg/internal/testing/controlplane/controlplane_suite_test.go b/pkg/internal/testing/controlplane/controlplane_suite_test.go
@@ -26,7 +26,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Control Plane Standup Unit Tests"
+const suiteName = "Control Plane Standup Unit Tests"
 
 func TestIntegration(t *testing.T) {
 	t.Parallel()
diff --git a/pkg/internal/testing/process/process_suite_test.go b/pkg/internal/testing/process/process_suite_test.go
@@ -26,7 +26,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Envtest Process Launcher Suite"
+const suiteName = "Envtest Process Launcher Suite"
 
 func TestInternal(t *testing.T) {
 	t.Parallel()
diff --git a/pkg/log/log_suite_test.go b/pkg/log/log_suite_test.go
@@ -25,7 +25,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Log Suite"
+const suiteName = "Log Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/log/zap/zap_suite_test.go b/pkg/log/zap/zap_suite_test.go
@@ -25,7 +25,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Zap Log Suite"
+const suiteName = "Zap Log Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/manager/manager_suite_test.go b/pkg/manager/manager_suite_test.go
@@ -33,7 +33,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/metrics"
 )
 
-var suiteName = "Manager Suite"
+const suiteName = "Manager Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/manager/signals/signals_suite_test.go b/pkg/manager/signals/signals_suite_test.go
@@ -26,7 +26,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Runtime Signal Suite"
+const suiteName = "Runtime Signal Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/predicate/predicate_suite_test.go b/pkg/predicate/predicate_suite_test.go
@@ -27,7 +27,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Predicate Suite"
+const suiteName = "Predicate Suite"
 
 func TestPredicate(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/reconcile/reconcile_suite_test.go b/pkg/reconcile/reconcile_suite_test.go
@@ -27,7 +27,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Reconcile Suite"
+const suiteName = "Reconcile Suite"
 
 func TestReconcile(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/runtime/inject/inject_suite_test.go b/pkg/runtime/inject/inject_suite_test.go
@@ -25,7 +25,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Runtime Injection Suite"
+const suiteName = "Runtime Injection Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/scheme/scheme_suite_test.go b/pkg/scheme/scheme_suite_test.go
@@ -26,7 +26,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
 )
 
-var suiteName = "Scheme Suite"
+const suiteName = "Scheme Suite"
 
 func TestScheme(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/source/internal/internal_suite_test.go b/pkg/source/internal/internal_suite_test.go
@@ -27,7 +27,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Source Internal Suite"
+const suiteName = "Source Internal Suite"
 
 func TestInternal(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/source/source_suite_test.go b/pkg/source/source_suite_test.go
@@ -32,7 +32,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Source Suite"
+const suiteName = "Source Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/webhook/admission/admission_suite_test.go b/pkg/webhook/admission/admission_suite_test.go
@@ -28,7 +28,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Admission Webhook Suite"
+const suiteName = "Admission Webhook Suite"
 
 func TestAdmissionWebhook(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/webhook/authentication/authentication_suite_test.go b/pkg/webhook/authentication/authentication_suite_test.go
@@ -28,7 +28,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Authentication Webhook Suite"
+const suiteName = "Authentication Webhook Suite"
 
 func TestAuthenticationWebhook(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/webhook/conversion/conversion_suite_test.go b/pkg/webhook/conversion/conversion_suite_test.go
@@ -27,7 +27,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "CRD conversion Suite"
+const suiteName = "CRD conversion Suite"
 
 func TestConversionWebhook(t *testing.T) {
 	RegisterFailHandler(Fail)
diff --git a/pkg/webhook/webhook_suite_test.go b/pkg/webhook/webhook_suite_test.go
@@ -33,7 +33,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 )
 
-var suiteName = "Webhook Integration Suite"
+const suiteName = "Webhook Integration Suite"
 
 func TestSource(t *testing.T) {
 	RegisterFailHandler(Fail)

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ import (`
`37`	`37`	`"sigs.k8s.io/controller-runtime/pkg/webhook"`
`38`	`38`	`)`
`39`	`39`
`40`		`-var suiteName = "application Suite"`
	`40`	`+const suiteName = "application Suite"`
`41`	`41`
`42`	`42`	`func TestBuilder(t *testing.T) {`
`43`	`43`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ import (`
`30`	`30`	`"sigs.k8s.io/controller-runtime/pkg/log/zap"`
`31`	`31`	`)`
`32`	`32`
`33`		`-var suiteName = "Cache Suite"`
	`33`	`+const suiteName = "Cache Suite"`
`34`	`34`
`35`	`35`	`func TestSource(t *testing.T) {`
`36`	`36`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ import (`
`25`	`25`	`"sigs.k8s.io/controller-runtime/pkg/envtest/printer"`
`26`	`26`	`)`
`27`	`27`
`28`		`-var suiteName = "Cache Internal Suite"`
	`28`	`+const suiteName = "Cache Internal Suite"`
`29`	`29`
`30`	`30`	`func TestSource(t *testing.T) {`
`31`	`31`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ import (`
`29`	`29`	`"sigs.k8s.io/controller-runtime/pkg/log/zap"`
`30`	`30`	`)`
`31`	`31`
`32`		`-var suiteName = "API Utilities Test Suite"`
	`32`	`+const suiteName = "API Utilities Test Suite"`
`33`	`33`
`34`	`34`	`func TestSource(t *testing.T) {`
`35`	`35`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ import (`
`33`	`33`	`"sigs.k8s.io/controller-runtime/pkg/log/zap"`
`34`	`34`	`)`
`35`	`35`
`36`		`-var suiteName = "Client Suite"`
	`36`	`+const suiteName = "Client Suite"`
`37`	`37`
`38`	`38`	`func TestSource(t *testing.T) {`
`39`	`39`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ import (`
`28`	`28`	`"sigs.k8s.io/controller-runtime/pkg/log/zap"`
`29`	`29`	`)`
`30`	`30`
`31`		`-var suiteName = "Client Config Test Suite"`
	`31`	`+const suiteName = "Client Config Test Suite"`
`32`	`32`
`33`	`33`	`func TestConfig(t *testing.T) {`
`34`	`34`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ import (`
`31`	`31`	`"sigs.k8s.io/controller-runtime/pkg/log/zap"`
`32`	`32`	`)`
`33`	`33`
`34`		`-var suiteName = "Cluster Suite"`
	`34`	`+const suiteName = "Cluster Suite"`
`35`	`35`
`36`	`36`	`func TestSource(t *testing.T) {`
`37`	`37`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ import (`
`26`	`26`	`"sigs.k8s.io/controller-runtime/pkg/envtest/printer"`
`27`	`27`	`)`
`28`	`28`
`29`		`-var suiteName = "Config Suite"`
	`29`	`+const suiteName = "Config Suite"`
`30`	`30`
`31`	`31`	`func TestScheme(t *testing.T) {`
`32`	`32`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ func (f mockFinalizer) Finalize(context.Context, client.Object) (Result, error)`
`23`	`23`	`return f.result, f.err`
`24`	`24`	`}`
`25`	`25`
`26`		`-var suiteName = "Finalizer Suite"`
	`26`	`+const suiteName = "Finalizer Suite"`
`27`	`27`
`28`	`28`	`func TestFinalizer(t *testing.T) {`
`29`	`29`	`RegisterFailHandler(Fail)`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ import (`
`27`	`27`	`"sigs.k8s.io/controller-runtime/pkg/log/zap"`
`28`	`28`	`)`
`29`	`29`
`30`		`-var suiteName = "Healthz Suite"`
	`30`	`+const suiteName = "Healthz Suite"`
`31`	`31`
`32`	`32`	`func TestHealthz(t *testing.T) {`
`33`	`33`	`RegisterFailHandler(Fail)`