Skip to content

Commit b7e8ceb

Browse files
committed
Quiet context.Canceled errors during shutdown
Runnable implementations that return ctx.Err() cause a spurious "error received after stop" log message.
1 parent 2136860 commit b7e8ceb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/manager/internal.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -485,8 +485,8 @@ func (cm *controllerManager) engageStopProcedure(stopComplete <-chan struct{}) e
485485
cm.internalCancel()
486486
})
487487
select {
488-
case err, ok := <-cm.errChan:
489-
if ok {
488+
case err := <-cm.errChan:
489+
if !errors.Is(err, context.Canceled) {
490490
cm.logger.Error(err, "error received after stop sequence was engaged")
491491
}
492492
case <-stopComplete:

0 commit comments

Comments
 (0)