⚠️ Remove deprecated NewFakeClient function, replace with scheme

Signed-off-by: Vince Prignano <[email protected]>

Author: vincepri

pkg/client/fake/client.go

@@ -56,18 +56,11 @@ const (
 	maxGeneratedNameLength = maxNameLength - randomLength
 )
 
-// NewFakeClient creates a new fake client for testing.
-// You can choose to initialize it with a slice of runtime.Object.
-// Deprecated: use NewFakeClientWithScheme.  You should always be
-// passing an explicit Scheme.
-func NewFakeClient(initObjs ...runtime.Object) client.Client {
-	return NewFakeClientWithScheme(scheme.Scheme, initObjs...)
-}
-
-// NewFakeClientWithScheme creates a new fake client with the given scheme
+// NewFakeClient creates a new fake client with the given scheme
 // for testing.
+//
 // You can choose to initialize it with a slice of runtime.Object.
-func NewFakeClientWithScheme(clientScheme *runtime.Scheme, initObjs ...runtime.Object) client.Client {
+func NewFakeClient(clientScheme *runtime.Scheme, initObjs ...runtime.Object) client.Client {
 	tracker := testing.NewObjectTracker(clientScheme, scheme.Codecs.UniversalDecoder())
 	for _, obj := range initObjs {
 		err := tracker.Add(obj)

pkg/client/fake/client_test.go

@@ -414,20 +414,12 @@ var _ = Describe("Fake client", func() {
 		})
 	}
 
-	Context("with default scheme.Scheme", func() {
-		BeforeEach(func(done Done) {
-			cl = NewFakeClient(dep, dep2, cm)
-			close(done)
-		})
-		AssertClientBehavior()
-	})
-
 	Context("with given scheme", func() {
 		BeforeEach(func(done Done) {
 			scheme := runtime.NewScheme()
 			Expect(corev1.AddToScheme(scheme)).To(Succeed())
 			Expect(appsv1.AddToScheme(scheme)).To(Succeed())
-			cl = NewFakeClientWithScheme(scheme, dep, dep2, cm)
+			cl = NewFakeClient(scheme, dep, dep2, cm)
 			close(done)
 		})
 		AssertClientBehavior()