Skip to content

Commit bdb3f84

Browse files
authored
Merge pull request #1400 from alvaroaleman/build-remove-restconfig
🏃 Builder: Remove unused restconfig attribute
2 parents da5d0bc + 117db7d commit bdb3f84

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

pkg/builder/controller.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"github.com/go-logr/logr"
2424
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2525
"k8s.io/apimachinery/pkg/runtime/schema"
26-
"k8s.io/client-go/rest"
2726

2827
"sigs.k8s.io/controller-runtime/pkg/client"
2928
"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
@@ -57,7 +56,6 @@ type Builder struct {
5756
watchesInput []WatchesInput
5857
mgr manager.Manager
5958
globalPredicates []predicate.Predicate
60-
config *rest.Config
6159
ctrl controller.Controller
6260
ctrlOptions controller.Options
6361
name string
@@ -188,9 +186,6 @@ func (blder *Builder) Build(r reconcile.Reconciler) (controller.Controller, erro
188186
return nil, fmt.Errorf("must provide an object for reconciliation")
189187
}
190188

191-
// Set the Config
192-
blder.loadRestConfig()
193-
194189
// Set the ControllerManagedBy
195190
if err := blder.doController(r); err != nil {
196191
return nil, err
@@ -273,12 +268,6 @@ func (blder *Builder) doWatch() error {
273268
return nil
274269
}
275270

276-
func (blder *Builder) loadRestConfig() {
277-
if blder.config == nil {
278-
blder.config = blder.mgr.GetConfig()
279-
}
280-
}
281-
282271
func (blder *Builder) getControllerName(gvk schema.GroupVersionKind) string {
283272
if blder.name != "" {
284273
return blder.name

0 commit comments

Comments
 (0)