Skip to content

Commit be832a1

Browse files
authored
Merge pull request #1024 from vincepri/seedling
Change other/minor emoji for PRs to 🌱
2 parents 6b734aa + c0ab285 commit be832a1

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<!-- please add a :running: (`:running:`) to the title of this PR, and delete this line and similar ones -->
1+
<!-- please add a :seedling: (`:seedling:`) to the title of this PR, and delete this line and similar ones -->
22

33
<!-- What does this do, and why do we need it? -->

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<!-- please add a icon to the title of this PR (see VERSIONING.md), and delete this line and similar ones -->
2-
<!-- the icon will be either ⚠ (:warning:, major), ✨ (:sparkles, minor), 🐛 (:bug:, patch), 📖 (:book:, docs), or 🏃 (:running:, other) -->
2+
<!-- the icon will be either ⚠ (:warning:, major), ✨ (:sparkles, minor), 🐛 (:bug:, patch), 📖 (:book:, docs), or 🌱 (:seedling:, other) -->
33

44
<!-- What does this do, and why do we need it? -->

VERSIONING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ a:
9191
- Non-breaking feature: :sparkles: (`:sparkles:`)
9292
- Patch fix: :bug: (`:bug:`)
9393
- Docs: :book: (`:book:`)
94-
- Infra/Tests/Other: :running: (`:running:`)
94+
- Infra/Tests/Other: :seedling: (`:seedling:`)
9595
- No release note: :ghost: (`:ghost:`)
9696

9797
Use :ghost: (no release note) only for the PRs that change or revert unreleased
@@ -156,7 +156,7 @@ after that.
156156

157157
3. Add a release for controller-runtime on GitHub, using those release
158158
notes, with a title of `vX.Y.Z`.
159-
159+
160160
4. Do a similar process for
161161
[controller-tools](https://github.com/kubernetes-sigs/controller-tools)
162162

@@ -210,10 +210,10 @@ converging on a ergonomic API.
210210

211211
- Users will intuitively see `List`, and use that in new projects, even
212212
if it's marked as deprecated.
213-
213+
214214
- Users who don't notice the deprecation may be confused as to the
215215
difference between `List` and `ListParametric`.
216-
216+
217217
- It's not immediately obvious in isolation (e.g. in surrounding code)
218218
why the method is called `ListParametric`, and may cause confusion
219219
when reading code that makes use of that method.
@@ -229,8 +229,8 @@ Development branches:
229229

230230
- don't win us much in terms of maintenance in the case of breaking
231231
changes (we still have to merge/manage multiple branches for development
232-
and stable)
233-
232+
and stable)
233+
234234
- can be confusing to contributors, who often expect master to have the
235235
latest changes.
236236

hack/release/common.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ cr_minor_pattern=":sparkles:|$(printf "\xe2\x9c\xa8")"
66
cr_patch_pattern=":bug:|$(printf "\xf0\x9f\x90\x9b")"
77
cr_docs_pattern=":book:|$(printf "\xf0\x9f\x93\x96")"
88
cr_no_release_note_pattern=":ghost:|$(printf "\xf0\x9f\x91\xbb")"
9-
cr_other_pattern=":running:|$(printf "\xf0\x9f\x8f\x83")"
10-
cr_all_pattern="${cr_major_pattern}|${cr_minor_pattern}|${cr_patch_pattern}|${cr_docs_pattern}|${cr_other_pattern}"
9+
cr_other_pattern=":seedling:|$(printf "\xf0\x9f\x8f\x83")"
10+
cr_other_old_pattern=":running:|$(printf "\xf0\x9f\x8f\x83")"
11+
cr_all_pattern="${cr_major_pattern}|${cr_minor_pattern}|${cr_patch_pattern}|${cr_docs_pattern}|${cr_other_old_pattern}|${cr_other_pattern}"
1112

1213
# cr::symbol-type-raw turns :xyz: and the corresponding emoji
1314
# into one of "major", "minor", "patch", "docs", "other", or
@@ -32,6 +33,9 @@ cr::symbol-type-raw() {
3233
@(${cr_other_pattern})?('!'))
3334
echo "other"
3435
;;
36+
@(${cr_other_old_pattern})?('!'))
37+
echo "other"
38+
;;
3539
*)
3640
echo "unknown"
3741
;;

0 commit comments

Comments
 (0)