Fix lint errors

Author: pwittrock

pkg/controller/controller.go

@@ -54,6 +54,7 @@ type Controller interface {
 	Start(stop <-chan struct{}) error
 }
 
+// New returns a new Controller registered with mrg.
 func New(name string, mrg manager.Manager, options Options) (Controller, error) {
 	if options.Reconcile == nil {
 		return nil, fmt.Errorf("must specify Reconcile")
@@ -67,6 +68,14 @@ func New(name string, mrg manager.Manager, options Options) (Controller, error)
 		options.MaxConcurrentReconciles = 1
 	}
 
+	if options.Reconcile == nil {
+		options.Reconcile = reconcile.Func(func(o reconcile.Request) (reconcile.Result, error) {
+			log.Error(nil, "Reconcile function not implemented", "Controller", name)
+			fmt.Printf("Received Reconcile request on Controller %s for %s/%s", name, o.Namespace, o.Name)
+			return reconcile.Result{}, nil
+		})
+	}
+
 	// Inject dependencies into Reconcile
 	if err := mrg.SetFields(options.Reconcile); err != nil {
 		return nil, err
@@ -84,7 +93,6 @@ func New(name string, mrg manager.Manager, options Options) (Controller, error)
 		Name: name,
 	}
 
-	// Add the controller as a Manager componentsw
-	mrg.Add(c)
-	return c, nil
+	// Add the controller as a Manager components
+	return c, mrg.Add(c)
 }

pkg/handler/doc.go

@@ -15,7 +15,7 @@ limitations under the License.
 */
 
 /*
-Package eventhandler defines EventHandlers that enqueue reconcile.Requests in response to Create, Update, Deletion Events
+Package handler defines EventHandlers that enqueue reconcile.Requests in response to Create, Update, Deletion Events
 observed from Watching Kubernetes APIs.
 
 EventHandlers

pkg/internal/controller/controller.go

@@ -41,6 +41,7 @@ var log = logf.KBLog.WithName("controller")
 
 var _ inject.Injector = &Controller{}
 
+// Controller implements controller.Controller
 type Controller struct {
 	// Name is used to uniquely identify a Controller in tracing, logging and monitoring.  Name is required.
 	Name string
@@ -89,6 +90,7 @@ type Controller struct {
 	// TODO(community): Consider initializing a logger with the Controller Name as the tag
 }
 
+// Watch implements controller.Controller
 func (c *Controller) Watch(src source.Source, evthdler handler.EventHandler, prct ...predicate.Predicate) error {
 	c.mu.Lock()
 	defer c.mu.Unlock()
@@ -112,6 +114,7 @@ func (c *Controller) Watch(src source.Source, evthdler handler.EventHandler, prc
 	return src.Start(evthdler, c.Queue, prct...)
 }
 
+// Start implements controller.Controller
 func (c *Controller) Start(stop <-chan struct{}) error {
 	c.mu.Lock()
 	defer c.mu.Unlock()

pkg/manager/internal.go

@@ -93,7 +93,7 @@ func (cm *controllerManager) SetFields(i interface{}) error {
 	if _, err := inject.CacheInto(cm.cache, i); err != nil {
 		return err
 	}
-	if _, err := inject.InjectInjector(cm.SetFields, i); err != nil {
+	if _, err := inject.InjectorInto(cm.SetFields, i); err != nil {
 		return err
 	}
 	return nil

pkg/runtime/inject/inject.go

@@ -74,7 +74,7 @@ type Scheme interface {
 	InjectScheme(scheme *runtime.Scheme) error
 }
 
-// SchemeInto will set client and return the result on i if it implements Scheme.  Returns
+// SchemeInto will set scheme and return the result on i if it implements Scheme.  Returns
 // false if i does not implement Scheme.
 func SchemeInto(scheme *runtime.Scheme, i interface{}) (bool, error) {
 	if is, ok := i.(Scheme); ok {
@@ -86,11 +86,14 @@ func SchemeInto(scheme *runtime.Scheme, i interface{}) (bool, error) {
 // Func injects dependencies into i.
 type Func func(i interface{}) error
 
+// Injector is used by the ControllerManager to inject Func into Controllers
 type Injector interface {
 	InjectFunc(f Func) error
 }
 
-func InjectInjector(f Func, i interface{}) (bool, error) {
+// InjectorInto will set f and return the result on i if it implements Injector.  Returns
+// false if i does not implement Injector.
+func InjectorInto(f Func, i interface{}) (bool, error) {
 	if ii, ok := i.(Injector); ok {
 		return true, ii.InjectFunc(f)
 	}