Skip to content

Commit d29ad1c

Browse files
committed
bump golangci-lint to v1.18.0 for go1.13 support
1 parent b640e83 commit d29ad1c

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Please see https://git.k8s.io/community/CLA.md for more info
1818

1919
1. Setup tools
2020
```bash
21-
$ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.17.1
21+
$ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.18.0
2222
```
2323
1. Test
2424
```bash

hack/check-everything.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ function is_installed {
6767
}
6868

6969
function fetch_go_tools {
70-
header_text "Checking for gometalinter.v2"
70+
header_text "Checking for golangci-lint"
7171
if ! is_installed golangci-lint; then
7272
header_text "Installing golangci-lint"
73-
go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.17.1
73+
go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.18.0
7474
fi
7575
}
7676

hack/ci-check-everything.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export PATH=$(go env GOPATH)/bin:$PATH
2323
mkdir -p $(go env GOPATH)/bin
2424

2525
echo "Installing golangci-lint"
26-
curl --location --silent --retry 5 --fail https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.17.1
26+
curl --location --silent --retry 5 --fail https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.18.0
2727
echo "Finished installing golangci-lint"
2828

2929
$(dirname ${BASH_SOURCE})/check-everything.sh

0 commit comments

Comments
 (0)