Skip to content

Commit d2fc2de

Browse files
committed
Disable golint because go get is broken for the tool.
1 parent f870149 commit d2fc2de

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

.travis.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,10 @@ git:
1212

1313
go_import_path: github.com/kubernetes-sigs/controller-runtime
1414

15-
before_install:
16-
- go get -u github.com/golang/dep/cmd/dep
17-
18-
# Install must be set to prevent default `go get` to run.
19-
# The dependencies have already been vendored by `dep` so
20-
# we don't need to fetch them.
2115
install:
22-
- go get -u golang.org/x/lint/golint
23-
- go get -u gopkg.in/alecthomas/gometalinter.v2 && gometalinter.v2 --install
16+
- go get -u github.com/golang/dep/cmd/dep
17+
#- go get -u golang.org/x/lint/golint
18+
- go get -u gopkg.in/alecthomas/gometalinter.v2 && gometalinter.v2 --install
2419

2520
script:
2621
- TRACE=1 ./test.sh

test.sh

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,10 @@ function setup_envs {
9595
export TEST_ASSET_ETCD=$kb_root_dir/bin/etcd
9696
}
9797

98+
header_text "using tools"
99+
100+
which gometalinter.v2
101+
98102
# fetch the testing binaries - e.g. apiserver and etcd
99103
fetch_kb_tools
100104

@@ -105,9 +109,10 @@ header_text "running go vet"
105109

106110
go vet ./pkg/...
107111

108-
header_text "running golint"
109-
110-
golint -set_exit_status ./pkg/...
112+
# go get is broken for golint. re-enable this once it is fixed.
113+
#header_text "running golint"
114+
#
115+
#golint -set_exit_status ./pkg/...
111116

112117
header_text "running gometalinter.v2"
113118

0 commit comments

Comments
 (0)