Skip to content

Commit d451655

Browse files
committed
fixup! add new cache.Options field to customize transform
attempt to fix race introduced in test by not referring to modified variable within callback
1 parent 42167fb commit d451655

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

pkg/cache/cache_test.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,13 +167,19 @@ var _ = Describe("Cache with transformers", func() {
167167
})
168168

169169
BeforeEach(func() {
170-
transformerHits = make(chan struct{}, 10)
170+
hitsChan := make(chan struct{}, 10)
171171

172172
var err error
173173
var transform = func(i interface{}) (interface{}, error) {
174-
transformerHits <- struct{}{}
174+
select {
175+
case hitsChan <- struct{}{}:
176+
// Notified the hit
177+
default:
178+
// don't block on sending
179+
}
175180
return i, nil
176181
}
182+
transformerHits = hitsChan
177183

178184
clien, err = client.New(cfg, client.Options{})
179185
Expect(err).NotTo(HaveOccurred())
@@ -218,7 +224,6 @@ var _ = Describe("Cache with transformers", func() {
218224
informerCacheCancel()
219225

220226
// Reset channel for future tests
221-
close(transformerHits)
222227
transformerHits = nil
223228
})
224229

0 commit comments

Comments
 (0)