✨ webhook server doesn't use leader election by default

Mengqi Yu · Mengqi Yu · commit d8501855a3d3 · 2019-05-23T17:38:01.000-07:00
diff --git a/pkg/webhook/server.go b/pkg/webhook/server.go
@@ -89,6 +89,12 @@ func (s *Server) setDefaults() {
 	}
 }
 
+// NeedLeaderElection implements the LeaderElectionRunnable interface, which indicates
+// the webhook server doesn't need leader election.
+func (*Server) NeedLeaderElection() bool {
+	return false
+}
+
 // Register marks the given webhook as being served at the given path.
 // It panics if two hooks are registered on the same path.
 func (s *Server) Register(path string, hook http.Handler) {

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,12 @@ func (s *Server) setDefaults() {`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`
	`92`	`+// NeedLeaderElection implements the LeaderElectionRunnable interface, which indicates`
	`93`	`+// the webhook server doesn't need leader election.`
	`94`	`+func (*Server) NeedLeaderElection() bool {`
	`95`	`+ return false`
	`96`	`+}`
	`97`	`+`
`92`	`98`	`// Register marks the given webhook as being served at the given path.`
`93`	`99`	`// It panics if two hooks are registered on the same path.`
`94`	`100`	`func (s *Server) Register(path string, hook http.Handler) {`