Skip to content

Commit e3d87d7

Browse files
committed
add missing generic version of ResourceVersionChangedPredicate
Signed-off-by: Tim Ramlot <[email protected]>
1 parent 9bc967a commit e3d87d7

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

pkg/predicate/predicate.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,18 +145,21 @@ func NewTypedPredicateFuncs[T any](filter func(object T) bool) TypedFuncs[T] {
145145
}
146146
}
147147

148-
// ResourceVersionChangedPredicate implements a default update predicate function on resource version change.
149-
type ResourceVersionChangedPredicate struct {
150-
Funcs
148+
// GenerationChangedPredicate implements a default update predicate function on resource version change.
149+
type ResourceVersionChangedPredicate = TypedResourceVersionChangedPredicate[client.Object]
150+
151+
// TypedResourceVersionChangedPredicate implements a default update predicate function on resource version change.
152+
type TypedResourceVersionChangedPredicate[T metav1.Object] struct {
153+
TypedFuncs[T]
151154
}
152155

153156
// Update implements default UpdateEvent filter for validating resource version change.
154-
func (ResourceVersionChangedPredicate) Update(e event.UpdateEvent) bool {
155-
if e.ObjectOld == nil {
157+
func (TypedResourceVersionChangedPredicate[T]) Update(e event.TypedUpdateEvent[T]) bool {
158+
if isNil(e.ObjectOld) {
156159
log.Error(nil, "Update event has no old object to update", "event", e)
157160
return false
158161
}
159-
if e.ObjectNew == nil {
162+
if isNil(e.ObjectNew) {
160163
log.Error(nil, "Update event has no new object to update", "event", e)
161164
return false
162165
}

0 commit comments

Comments
 (0)