Skip to content

Commit e4e8977

Browse files
committed
⚠️ Remove error log in internal controller, set V=5 for Info
Signed-off-by: Vince Prignano <[email protected]>
1 parent 4ffd908 commit e4e8977

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

pkg/internal/controller/controller.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
234234
// resource to be synced.
235235
if result, err := c.Do.Reconcile(req); err != nil {
236236
c.Queue.AddRateLimited(req)
237-
log.Error(err, "Reconciler error")
238237
ctrlmetrics.ReconcileErrors.WithLabelValues(c.Name).Inc()
239238
ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "error").Inc()
240239
return false
@@ -257,9 +256,7 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
257256
// get queued again until another change happens.
258257
c.Queue.Forget(obj)
259258

260-
// TODO(directxman12): What does 1 mean? Do we want level constants? Do we want levels at all?
261-
log.V(1).Info("Successfully Reconciled")
262-
259+
log.V(5).Info("Successfully Reconciled")
263260
ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "success").Inc()
264261
// Return true, don't take a break
265262
return true

0 commit comments

Comments
 (0)