Skip to content

Commit ec38c3c

Browse files
authored
Merge pull request #1120 from Adirio/cleanup
✨ Cleanup scaffolding
2 parents f74cbf4 + a3f3553 commit ec38c3c

File tree

4 files changed

+13
-17
lines changed

4 files changed

+13
-17
lines changed

pkg/scaffold/v2/controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,10 @@ package controllers
7171
import (
7272
"context"
7373
74-
ctrl "sigs.k8s.io/controller-runtime"
75-
"sigs.k8s.io/controller-runtime/pkg/client"
7674
"github.com/go-logr/logr"
7775
"k8s.io/apimachinery/pkg/runtime"
76+
ctrl "sigs.k8s.io/controller-runtime"
77+
"sigs.k8s.io/controller-runtime/pkg/client"
7878
7979
{{ .Resource.GroupImportSafe }}{{ .Resource.Version }} "{{ .ResourcePackage }}/{{ .Resource.Version }}"
8080
)

pkg/scaffold/v2/controller_suitetest.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ var _ = BeforeSuite(func(done Done) {
112112
113113
// +kubebuilder:scaffold:scheme
114114
115-
116115
k8sClient, err = client.New(cfg, client.Options{Scheme: scheme.Scheme})
117116
Expect(err).ToNot(HaveOccurred())
118117
Expect(k8sClient).ToNot(BeNil())

pkg/scaffold/v2/group.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,8 @@ var groupTemplate = `{{ .Boilerplate }}
5555
package {{ .Resource.Version }}
5656
5757
import (
58-
"sigs.k8s.io/controller-runtime/pkg/scheme"
5958
"k8s.io/apimachinery/pkg/runtime/schema"
60-
logf "sigs.k8s.io/controller-runtime/pkg/runtime/log"
59+
"sigs.k8s.io/controller-runtime/pkg/scheme"
6160
)
6261
6362
var (

pkg/scaffold/v2/main.go

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ func (m *Main) Update(opts *MainUpdateOptions) error {
6363
addschemeCodeFragment := fmt.Sprintf(`_ = %s%s.AddToScheme(scheme)
6464
`, opts.Resource.GroupImportSafe, opts.Resource.Version)
6565
reconcilerSetupCodeFragment := fmt.Sprintf(`if err = (&controllers.%sReconciler{
66-
Client: mgr.GetClient(),
67-
Log: ctrl.Log.WithName("controllers").WithName("%s"),
68-
Scheme: mgr.GetScheme(),
66+
Client: mgr.GetClient(),
67+
Log: ctrl.Log.WithName("controllers").WithName("%s"),
68+
Scheme: mgr.GetScheme(),
6969
}).SetupWithManager(mgr); err != nil {
70-
setupLog.Error(err, "unable to create controller", "controller", "%s")
71-
os.Exit(1)
72-
}
70+
setupLog.Error(err, "unable to create controller", "controller", "%s")
71+
os.Exit(1)
72+
}
7373
`, opts.Resource.Kind, opts.Resource.Kind, opts.Resource.Kind)
7474
webhookSetupCodeFragment := fmt.Sprintf(`if err = (&%s%s.%s{}).SetupWebhookWithManager(mgr); err != nil {
7575
setupLog.Error(err, "unable to create webhook", "webhook", "%s")
@@ -130,14 +130,13 @@ package main
130130
131131
import (
132132
"flag"
133-
"os"
133+
"os"
134134
135+
"k8s.io/apimachinery/pkg/runtime"
135136
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
136137
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
137-
ctrl "sigs.k8s.io/controller-runtime"
138-
"sigs.k8s.io/controller-runtime/pkg/log/zap"
139-
"k8s.io/apimachinery/pkg/runtime"
140-
138+
ctrl "sigs.k8s.io/controller-runtime"
139+
"sigs.k8s.io/controller-runtime/pkg/log/zap"
141140
142141
%s
143142
)
@@ -176,7 +175,6 @@ func main() {
176175
os.Exit(1)
177176
}
178177
179-
180178
%s
181179
182180
setupLog.Info("starting manager")

0 commit comments

Comments
 (0)