⚠️ admission responses with raw Status

If a custom webhook validator returns a metav1.Status object as the error, the validation handler will build an admission response with this Status object as is, instead of building a new Status object based on err.Error()

This might be considered as a breaking change since the behaviour of the
validation handler is going to be slightly different from what the users
might expect based on the previous version of the code

Author: Eric Abramov

pkg/webhook/admission/response.go

@@ -80,17 +80,6 @@ func ValidationResponse(allowed bool, reason string) Response {
 	return resp
 }
 
-// ValidationResponseFromStatus returns a response for admitting a request with provided Status object.
-func ValidationResponseFromStatus(allowed bool, status *metav1.Status) Response {
-	resp := Response{
-		AdmissionResponse: admissionv1beta1.AdmissionResponse{
-			Allowed: allowed,
-			Result: status,
-		},
-	}
-	return resp
-}
-
 // PatchResponseFromRaw takes 2 byte arrays and returns a new response with json patch.
 // The original object should be passed in as raw bytes to avoid the roundtripping problem
 // described in https://github.com/kubernetes-sigs/kubebuilder/issues/510.