Skip to content

Commit feba3a3

Browse files
authored
Merge pull request #299 from mengqiy/coretype
fix core type controller
2 parents 0c35e81 + b4a39c0 commit feba3a3

File tree

4 files changed

+53
-9
lines changed

4 files changed

+53
-9
lines changed

cmd/Gopkg.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/kubebuilder/v1/api.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,5 +172,6 @@ func ResourceForFlags(f *flag.FlagSet) *resource.Resource {
172172
f.StringVar(&r.Kind, "kind", "", "resource Kind")
173173
f.StringVar(&r.Group, "group", "", "resource Group")
174174
f.StringVar(&r.Version, "version", "", "resource Version")
175+
f.BoolVar(&r.Namespaced, "namespaced", true, "resource is namespaced")
175176
return r
176177
}

cmd/vendor/sigs.k8s.io/controller-tools/pkg/scaffold/controller/controllertest.go

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

testv1.sh

Lines changed: 42 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,31 @@ function test_init_project_manual_dep_ensure {
3434

3535
function test_create_api_controller {
3636
header_text "performing creating api and controller"
37-
kubebuilder create api --group insect --version v1beta1 --kind Bee <<EOF
37+
kubebuilder create api --group insect --version v1beta1 --kind Bee --namespaced false <<EOF
38+
y
39+
y
40+
EOF
41+
}
42+
43+
function test_create_namespaced_api_controller {
44+
header_text "performing creating namespaced api and controller"
45+
kubebuilder create api --group insect --version v1beta1 --kind Bee --namespaced true <<EOF
3846
y
3947
y
4048
EOF
4149
}
4250

4351
function test_create_api_only {
4452
header_text "performing creating api only"
45-
kubebuilder create api --group insect --version v1beta1 --kind Bee <<EOF
53+
kubebuilder create api --group insect --version v1beta1 --kind Bee --namespaced false <<EOF
54+
y
55+
n
56+
EOF
57+
}
58+
59+
function test_create_namespaced_api_only {
60+
header_text "performing creating api only"
61+
kubebuilder create api --group insect --version v1beta1 --kind Bee --namespaced true <<EOF
4662
y
4763
n
4864
EOF
@@ -58,7 +74,15 @@ EOF
5874

5975
function test_create_coretype_controller {
6076
header_text "performing creating coretype controller"
61-
kubebuilder create api --group apps --version v1 --kind Deployment <<EOF
77+
kubebuilder create api --group apps --version v1 --kind Deployment --namespaced false <<EOF
78+
n
79+
y
80+
EOF
81+
}
82+
83+
function test_create_namespaced_coretype_controller {
84+
header_text "performing creating coretype controller"
85+
kubebuilder create api --group apps --version v1 --kind Deployment --namespaced true <<EOF
6286
n
6387
y
6488
EOF
@@ -80,13 +104,24 @@ prepare_testdir_under_gopath
80104
test_init_project
81105
test_create_api_controller
82106

107+
prepare_testdir_under_gopath
108+
test_init_project
109+
test_create_namespaced_api_controller
110+
83111
prepare_testdir_under_gopath
84112
test_init_project
85113
test_create_api_only
86114

87-
# enable this test case after fixing it
88-
#prepare_testdir_under_gopath
89-
#test_init_project
90-
#test_create_coretype_controller
115+
prepare_testdir_under_gopath
116+
test_init_project
117+
test_create_namespaced_api_only
118+
119+
prepare_testdir_under_gopath
120+
test_init_project
121+
test_create_coretype_controller
122+
123+
prepare_testdir_under_gopath
124+
test_init_project
125+
test_create_namespaced_coretype_controller
91126

92127
exit $rc

0 commit comments

Comments
 (0)