Unwrap error when checking for not found.

briantkennedy · briantkennedy · commit 4040df9f2acc · 2021-06-17T11:38:18.000-07:00
This has been logging erronious not found errors since the returned
error wraps the not found error.
diff --git a/pkg/patterns/declarative/reconciler.go b/pkg/patterns/declarative/reconciler.go
@@ -201,7 +201,7 @@ func (r *Reconciler) reconcileExists(ctx context.Context, name types.NamespacedN
 	for _, obj := range objects.Items {
 
 		unstruct, err := GetObjectFromCluster(obj, r)
-		if err != nil && !apierrors.IsNotFound(err) {
+		if err != nil && !apierrors.IsNotFound(errors.Unwrap(err)) {
 			log.WithValues("name", obj.Name).Error(err, "Unable to get resource")
 		}
 		if unstruct != nil {

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ func (r *Reconciler) reconcileExists(ctx context.Context, name types.NamespacedN`
`201`	`201`	`for _, obj := range objects.Items {`
`202`	`202`
`203`	`203`	`unstruct, err := GetObjectFromCluster(obj, r)`
`204`		`- if err != nil && !apierrors.IsNotFound(err) {`
	`204`	`+ if err != nil && !apierrors.IsNotFound(errors.Unwrap(err)) {`
`205`	`205`	`log.WithValues("name", obj.Name).Error(err, "Unable to get resource")`
`206`	`206`	`}`
`207`	`207`	`if unstruct != nil {`