Skip to content

Change assert library with cmp library in test #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2021
Merged

Change assert library with cmp library in test #156

merged 1 commit into from
Jul 26, 2021

Conversation

atoato88
Copy link
Contributor

What this PR does / why we need it:
This PR changes assert library with github.com/google/go-cmp/cmp library.
This is because for fitting to google go style guide, commented here.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Additional documentation:
None

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy March 23, 2021 09:55
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2021
@atoato88 atoato88 force-pushed the use-cmp-library-instead-assert branch 2 times, most recently from 274302a to af057e1 Compare March 23, 2021 10:28
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2021
@oomichi
Copy link

oomichi commented Jul 18, 2021

@atoato88 The change itself seems good for me.
But this needs to be rebased as the bot says.
Will you update this pull request?

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi July 18, 2021 21:05
@atoato88
Copy link
Contributor Author

OK, I'll rebase this.

@atoato88
Change assert library with cmp library
c3a6f1b 
This commit changes assert library with `github.com/google/go-cmp/cmp`
library.
This is because for fitting to google go style guide.
@atoato88 atoato88 force-pushed the use-cmp-library-instead-assert branch from af057e1 to c3a6f1b Compare July 18, 2021 21:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2021
@atoato88
Copy link
Contributor Author

rebased.

@oomichi
Copy link

oomichi commented Jul 20, 2021

Thanks for updating.
This seems good for the original comment from @justinsb

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@oomichi
Copy link

oomichi commented Jul 20, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2021
@justinsb
Copy link
Contributor

Thanks & sorry for the delay!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7468552 into kubernetes-sigs:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@justinsb justinsb

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atoato88 @fejta-bot @oomichi @justinsb @k8s-ci-robot