Skip to content

Commit 175713e

Browse files
authored
Merge pull request #2763 from camilamacedo86/fix-tralling-spaces
🐛 (kustomize/v1 and v2-alpha): fix spaces for comments and ensure additions
2 parents e67c488 + d35d15d commit 175713e

File tree

7 files changed

+70
-50
lines changed

7 files changed

+70
-50
lines changed

pkg/plugins/common/kustomize/v1/scaffolds/internal/templates/config/manager/controller_manager_config.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,14 @@ webhook:
5555
leaderElection:
5656
leaderElect: true
5757
resourceName: {{ hashFNV .Repo }}.{{ .Domain }}
58-
# leaderElectionReleaseOnCancel defines if the leader should step down volume
59-
# when the Manager ends. This requires the binary to immediately end when the
60-
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
61-
# speeds up voluntary leader transitions as the new leader don't have to wait
62-
# LeaseDuration time first.
63-
# In the default scaffold provided, the program ends immediately after
64-
# the manager stops, so would be fine to enable this option. However,
65-
# if you are doing or is intended to do any operation such as perform cleanups
66-
# after the manager stops then its usage might be unsafe.
67-
# leaderElectionReleaseOnCancel: true
58+
# leaderElectionReleaseOnCancel defines if the leader should step down volume
59+
# when the Manager ends. This requires the binary to immediately end when the
60+
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
61+
# speeds up voluntary leader transitions as the new leader don't have to wait
62+
# LeaseDuration time first.
63+
# In the default scaffold provided, the program ends immediately after
64+
# the manager stops, so would be fine to enable this option. However,
65+
# if you are doing or is intended to do any operation such as perform cleanups
66+
# after the manager stops then its usage might be unsafe.
67+
# leaderElectionReleaseOnCancel: true
6868
`

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/controller_manager_config.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,14 @@ webhook:
5555
leaderElection:
5656
leaderElect: true
5757
resourceName: {{ hashFNV .Repo }}.{{ .Domain }}
58+
# leaderElectionReleaseOnCancel defines if the leader should step down volume
59+
# when the Manager ends. This requires the binary to immediately end when the
60+
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
61+
# speeds up voluntary leader transitions as the new leader don't have to wait
62+
# LeaseDuration time first.
63+
# In the default scaffold provided, the program ends immediately after
64+
# the manager stops, so would be fine to enable this option. However,
65+
# if you are doing or is intended to do any operation such as perform cleanups
66+
# after the manager stops then its usage might be unsafe.
67+
# leaderElectionReleaseOnCancel: true
5868
`

testdata/project-v3-addon/config/manager/controller_manager_config.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ webhook:
99
leaderElection:
1010
leaderElect: true
1111
resourceName: 52ea9610.testproject.org
12-
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13-
# when the Manager ends. This requires the binary to immediately end when the
14-
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15-
# speeds up voluntary leader transitions as the new leader don't have to wait
16-
# LeaseDuration time first.
17-
# In the default scaffold provided, the program ends immediately after
18-
# the manager stops, so would be fine to enable this option. However,
19-
# if you are doing or is intended to do any operation such as perform cleanups
20-
# after the manager stops then its usage might be unsafe.
21-
# leaderElectionReleaseOnCancel: true
12+
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13+
# when the Manager ends. This requires the binary to immediately end when the
14+
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15+
# speeds up voluntary leader transitions as the new leader don't have to wait
16+
# LeaseDuration time first.
17+
# In the default scaffold provided, the program ends immediately after
18+
# the manager stops, so would be fine to enable this option. However,
19+
# if you are doing or is intended to do any operation such as perform cleanups
20+
# after the manager stops then its usage might be unsafe.
21+
# leaderElectionReleaseOnCancel: true

testdata/project-v3-config/config/manager/controller_manager_config.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ webhook:
99
leaderElection:
1010
leaderElect: true
1111
resourceName: 6858fb70.testproject.org
12-
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13-
# when the Manager ends. This requires the binary to immediately end when the
14-
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15-
# speeds up voluntary leader transitions as the new leader don't have to wait
16-
# LeaseDuration time first.
17-
# In the default scaffold provided, the program ends immediately after
18-
# the manager stops, so would be fine to enable this option. However,
19-
# if you are doing or is intended to do any operation such as perform cleanups
20-
# after the manager stops then its usage might be unsafe.
21-
# leaderElectionReleaseOnCancel: true
12+
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13+
# when the Manager ends. This requires the binary to immediately end when the
14+
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15+
# speeds up voluntary leader transitions as the new leader don't have to wait
16+
# LeaseDuration time first.
17+
# In the default scaffold provided, the program ends immediately after
18+
# the manager stops, so would be fine to enable this option. However,
19+
# if you are doing or is intended to do any operation such as perform cleanups
20+
# after the manager stops then its usage might be unsafe.
21+
# leaderElectionReleaseOnCancel: true

testdata/project-v3-multigroup/config/manager/controller_manager_config.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ webhook:
99
leaderElection:
1010
leaderElect: true
1111
resourceName: 14be1926.testproject.org
12-
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13-
# when the Manager ends. This requires the binary to immediately end when the
14-
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15-
# speeds up voluntary leader transitions as the new leader don't have to wait
16-
# LeaseDuration time first.
17-
# In the default scaffold provided, the program ends immediately after
18-
# the manager stops, so would be fine to enable this option. However,
19-
# if you are doing or is intended to do any operation such as perform cleanups
20-
# after the manager stops then its usage might be unsafe.
21-
# leaderElectionReleaseOnCancel: true
12+
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13+
# when the Manager ends. This requires the binary to immediately end when the
14+
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15+
# speeds up voluntary leader transitions as the new leader don't have to wait
16+
# LeaseDuration time first.
17+
# In the default scaffold provided, the program ends immediately after
18+
# the manager stops, so would be fine to enable this option. However,
19+
# if you are doing or is intended to do any operation such as perform cleanups
20+
# after the manager stops then its usage might be unsafe.
21+
# leaderElectionReleaseOnCancel: true

testdata/project-v3-with-kustomize-v2/config/manager/controller_manager_config.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,13 @@ webhook:
99
leaderElection:
1010
leaderElect: true
1111
resourceName: f4c39f8b.testproject.org
12+
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13+
# when the Manager ends. This requires the binary to immediately end when the
14+
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15+
# speeds up voluntary leader transitions as the new leader don't have to wait
16+
# LeaseDuration time first.
17+
# In the default scaffold provided, the program ends immediately after
18+
# the manager stops, so would be fine to enable this option. However,
19+
# if you are doing or is intended to do any operation such as perform cleanups
20+
# after the manager stops then its usage might be unsafe.
21+
# leaderElectionReleaseOnCancel: true

testdata/project-v3/config/manager/controller_manager_config.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ webhook:
99
leaderElection:
1010
leaderElect: true
1111
resourceName: dd1da13f.testproject.org
12-
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13-
# when the Manager ends. This requires the binary to immediately end when the
14-
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15-
# speeds up voluntary leader transitions as the new leader don't have to wait
16-
# LeaseDuration time first.
17-
# In the default scaffold provided, the program ends immediately after
18-
# the manager stops, so would be fine to enable this option. However,
19-
# if you are doing or is intended to do any operation such as perform cleanups
20-
# after the manager stops then its usage might be unsafe.
21-
# leaderElectionReleaseOnCancel: true
12+
# leaderElectionReleaseOnCancel defines if the leader should step down volume
13+
# when the Manager ends. This requires the binary to immediately end when the
14+
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
15+
# speeds up voluntary leader transitions as the new leader don't have to wait
16+
# LeaseDuration time first.
17+
# In the default scaffold provided, the program ends immediately after
18+
# the manager stops, so would be fine to enable this option. However,
19+
# if you are doing or is intended to do any operation such as perform cleanups
20+
# after the manager stops then its usage might be unsafe.
21+
# leaderElectionReleaseOnCancel: true

0 commit comments

Comments
 (0)