Skip to content

Commit efbbdd6

Browse files
authored
[ADT] Make DenseMap::init() private (NFC) (llvm#134229)
I believe this method was not supposed to be public, as it has additional preconditions (it will misbehave when called on a non-empty DenseMap). The public API for this is reserve().
1 parent c235589 commit efbbdd6

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

llvm/include/llvm/ADT/DenseMap.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -806,16 +806,6 @@ class DenseMap : public DenseMapBase<DenseMap<KeyT, ValueT, KeyInfoT, BucketT>,
806806
}
807807
}
808808

809-
void init(unsigned InitNumEntries) {
810-
auto InitBuckets = BaseT::getMinBucketToReserveForEntries(InitNumEntries);
811-
if (allocateBuckets(InitBuckets)) {
812-
this->BaseT::initEmpty();
813-
} else {
814-
NumEntries = 0;
815-
NumTombstones = 0;
816-
}
817-
}
818-
819809
void grow(unsigned AtLeast) {
820810
unsigned OldNumBuckets = NumBuckets;
821811
BucketT *OldBuckets = Buckets;
@@ -878,6 +868,16 @@ class DenseMap : public DenseMapBase<DenseMap<KeyT, ValueT, KeyInfoT, BucketT>,
878868
allocate_buffer(sizeof(BucketT) * NumBuckets, alignof(BucketT)));
879869
return true;
880870
}
871+
872+
void init(unsigned InitNumEntries) {
873+
auto InitBuckets = BaseT::getMinBucketToReserveForEntries(InitNumEntries);
874+
if (allocateBuckets(InitBuckets)) {
875+
this->BaseT::initEmpty();
876+
} else {
877+
NumEntries = 0;
878+
NumTombstones = 0;
879+
}
880+
}
881881
};
882882

883883
template <typename KeyT, typename ValueT, unsigned InlineBuckets = 4,

llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -897,8 +897,8 @@ class MemLocFragmentFill {
897897
Worklist.push(RPONumber);
898898
++RPONumber;
899899
}
900-
LiveIn.init(RPONumber);
901-
LiveOut.init(RPONumber);
900+
LiveIn.reserve(RPONumber);
901+
LiveOut.reserve(RPONumber);
902902
}
903903

904904
// Perform the traversal.
@@ -2318,8 +2318,8 @@ bool AssignmentTrackingLowering::run(FunctionVarLocsBuilder *FnVarLocsBuilder) {
23182318
Worklist.push(RPONumber);
23192319
++RPONumber;
23202320
}
2321-
LiveIn.init(RPONumber);
2322-
LiveOut.init(RPONumber);
2321+
LiveIn.reserve(RPONumber);
2322+
LiveOut.reserve(RPONumber);
23232323
}
23242324

23252325
// Perform the traversal.

0 commit comments

Comments
 (0)