Skip to content

Commit f87e9d4

Browse files
[libcxx][test] Update picolibc version (llvm#100348)
This is the latest as of today, and it fixes one of the xfails. Since picolibc/picolibc@5e4d0c8, TIME_UTC is defined.
1 parent 4ca1a90 commit f87e9d4

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111

1212
// UNSUPPORTED: c++03, c++11, c++14
1313

14-
// picolibc doesn't define TIME_UTC.
15-
// XFAIL: LIBCXX-PICOLIBC-FIXME
16-
1714
// ::timespec_get is provided by the C library, but it's marked as
1815
// unavailable until macOS 10.15
1916
// XFAIL: target={{.+}}-apple-macosx10.{{13|14}}

libcxx/utils/ci/build-picolibc.sh

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,8 @@ picolibc_source_dir="${build_dir}/picolibc-source"
6969
picolibc_build_dir="${build_dir}/picolibc-build"
7070
mkdir -p "${picolibc_source_dir}"
7171
mkdir -p "${picolibc_build_dir}"
72-
# Download the version of picolibc that was the latest at the time this script was written.
73-
# Following changes are required and were introduced after version 1.8.5:
74-
# - updated semihost arguments handling,
75-
# - added missing macros in stdio.h
76-
# - external linkage for isblank
77-
# Version following 1.8.5, was not released by the time of writing.
78-
picolibc_commit="04a90c56d7aac61880f205ec29b3dce6a9de0342"
72+
# Download a known good version of picolibc.
73+
picolibc_commit="48fbc2009c6473293d03d5ec6f190565c6223a5c"
7974
curl -L "https://github.com/picolibc/picolibc/archive/${picolibc_commit}.zip" --output "${picolibc_source_dir}/picolibc.zip"
8075
unzip -q "${picolibc_source_dir}/picolibc.zip" -d "${picolibc_source_dir}"
8176
mv "${picolibc_source_dir}/picolibc-${picolibc_commit}"/* "${picolibc_source_dir}"

0 commit comments

Comments
 (0)