[NFC][sanitizer] Micro optimize push_back()

vitalybuka · vitalybuka · commit 2aef60532f04 · 2023-05-28T17:53:54.000-07:00
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_common.h b/compiler-rt/lib/sanitizer_common/sanitizer_common.h
@@ -519,8 +519,8 @@ class InternalMmapVectorNoCtor {
     return data_[i];
   }
   void push_back(const T &element) {
-    CHECK_LE(size_, capacity());
-    if (size_ == capacity()) {
+    if (UNLIKELY(size_ >= capacity())) {
+      CHECK_EQ(size_, capacity());
       uptr new_capacity = RoundUpToPowerOfTwo(size_ + 1);
       Realloc(new_capacity);
     }
@@ -580,7 +580,7 @@ class InternalMmapVectorNoCtor {
   }
 
  private:
-  void Realloc(uptr new_capacity) {
+  NOINLINE void Realloc(uptr new_capacity) {
     CHECK_GT(new_capacity, 0);
     CHECK_LE(size_, new_capacity);
     uptr new_capacity_bytes =

Original file line number	Diff line number	Diff line change
`@@ -519,8 +519,8 @@ class InternalMmapVectorNoCtor {`
`519`	`519`	`return data_[i];`
`520`	`520`	`}`
`521`	`521`	`void push_back(const T &element) {`
`522`		`- CHECK_LE(size_, capacity());`
`523`		`- if (size_ == capacity()) {`
	`522`	`+ if (UNLIKELY(size_ >= capacity())) {`
	`523`	`+ CHECK_EQ(size_, capacity());`
`524`	`524`	`uptr new_capacity = RoundUpToPowerOfTwo(size_ + 1);`
`525`	`525`	`Realloc(new_capacity);`
`526`	`526`	`}`
`@@ -580,7 +580,7 @@ class InternalMmapVectorNoCtor {`
`580`	`580`	`}`
`581`	`581`
`582`	`582`	`private:`
`583`		`- void Realloc(uptr new_capacity) {`
	`583`	`+ NOINLINE void Realloc(uptr new_capacity) {`
`584`	`584`	`CHECK_GT(new_capacity, 0);`
`585`	`585`	`CHECK_LE(size_, new_capacity);`
`586`	`586`	`uptr new_capacity_bytes =`