Skip to content

Commit d58fe4c

Browse files
committed
[FMV][AArch64] Remove features which expose non exploitable runtime behavior.
Feature dit provides independent timing for data processing instructions according to the value CPSR.DIT of the Current Program Status Register. The runtime detection in FMV does not examine the content of control registers, therefore such features are not suitable for runtime dispatch since they cannot be exploited in a meaningful way. See the ACLE patch for more info: ARM-software/acle#355 Depends on llvm/llvm-project#114387
1 parent c397861 commit d58fe4c

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

SingleSource/UnitTests/AArch64/acle-fmv-features.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,6 @@ CHECK(i8mm, i8mm, i8mm, false, {
162162
: : : "v0"
163163
);
164164
})
165-
CHECK(dit, dit, dit, false, {
166-
asm volatile (
167-
"msr DIT, x0"
168-
: : : "x0"
169-
);
170-
})
171165
CHECK(fp16, fp16, fp16, false, {
172166
asm volatile (
173167
"fmov h0, #0"
@@ -409,7 +403,6 @@ int main(int, const char **) {
409403
check_dpb2();
410404
check_bf16();
411405
check_i8mm();
412-
check_dit();
413406
check_fp16();
414407
check_ssbs();
415408
check_bti();

SingleSource/UnitTests/AArch64/acle-fmv-features.reference_output

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ dpb
1414
dpb2
1515
bf16
1616
i8mm
17-
dit
1817
fp16
1918
ssbs
2019
bti

0 commit comments

Comments
 (0)