Skip to content

Commit 5761e7a

Browse files
Pedro FontanaPedro Fontana
Pedro Fontana
authored and
Pedro Fontana
committed
Remove CairoRunError::CairoPieValidation error
1 parent f3161e3 commit 5761e7a

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

vm/src/cairo_run.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ use crate::{
1313

1414
use crate::Felt252;
1515
use bincode::enc::write::Writer;
16-
1716
use thiserror_no_std::Error;
1817

1918
#[cfg(feature = "arbitrary")]
@@ -126,7 +125,8 @@ pub fn cairo_run_pie(
126125
{
127126
return Err(RunnerError::PieNStepsVsRunResourcesNStepsMismatch.into());
128127
}
129-
pie.run_validity_checks()?;
128+
pie.run_validity_checks()
129+
.map_err(|cairo_pie_err| CairoRunError::Runner(cairo_pie_err.into()))?;
130130
let secure_run = cairo_run_config.secure_run.unwrap_or(true);
131131

132132
let allow_missing_builtins = cairo_run_config.allow_missing_builtins.unwrap_or_default();
@@ -170,7 +170,8 @@ pub fn cairo_run_pie(
170170
// Check that the Cairo PIE produced by this run is compatible with the Cairo PIE received
171171
cairo_runner
172172
.get_cairo_pie(&vm)?
173-
.check_pie_compatibility(pie)?;
173+
.check_pie_compatibility(pie)
174+
.map_err(|cairo_pie_err| CairoRunError::Runner(cairo_pie_err.into()))?;
174175
}
175176
cairo_runner.relocate(&mut vm, cairo_run_config.relocate_mem)?;
176177

vm/src/vm/errors/cairo_run_errors.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
use thiserror_no_std::Error;
22

3-
use super::cairo_pie_errors::CairoPieValidationError;
43
use super::memory_errors::MemoryError;
54
use super::vm_exception::VmException;
65
use crate::types::errors::program_errors::ProgramError;
@@ -22,6 +21,4 @@ pub enum CairoRunError {
2221
MemoryError(#[from] MemoryError),
2322
#[error(transparent)]
2423
VmException(#[from] VmException),
25-
#[error("Cairo Pie validation failed: {0}")]
26-
CairoPieValidation(#[from] CairoPieValidationError),
2724
}

vm/src/vm/errors/runner_errors.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use crate::types::builtin_name::BuiltinName;
66
use crate::types::layout_name::LayoutName;
77
use thiserror_no_std::Error;
88

9+
use super::cairo_pie_errors::CairoPieValidationError;
910
use super::{memory_errors::MemoryError, trace_errors::TraceError};
1011
use crate::types::{errors::math_errors::MathError, relocatable::Relocatable};
1112
use crate::Felt252;
@@ -132,6 +133,8 @@ pub enum RunnerError {
132133
CairoPieProofMode,
133134
#[error("{0}: Invalid additional data")]
134135
InvalidAdditionalData(BuiltinName),
136+
#[error("Cairo Pie validation failed: {0}")]
137+
CairoPieValidation(#[from] CairoPieValidationError),
135138
}
136139

137140
#[cfg(test)]

0 commit comments

Comments
 (0)