Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Add getters for StateDiff fields #711

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Conversation

juanbono
Copy link
Collaborator

@juanbono juanbono commented Jun 29, 2023

Add getters for StateDiff fields

Description

Solves #707
It adds getters for every field of the StateDiff struct.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@juanbono juanbono linked an issue Jun 29, 2023 that may be closed by this pull request
@juanbono juanbono self-assigned this Jun 29, 2023
@Oppen
Copy link
Contributor

Oppen commented Jun 29, 2023

It makes sense to make the fields public.

Why does it? Why is it necessary?

Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this

@juanbono juanbono changed the title make StateDiff members public Add getters for StateDiff fields Jul 3, 2023
@juanbono juanbono requested a review from SantiagoPittella July 3, 2023 12:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #711 (afce0e3) into main (5361f71) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files          52       52           
  Lines       11792    11792           
=======================================
  Hits        10892    10892           
  Misses        900      900           
Impacted Files Coverage Δ
src/state/mod.rs 99.29% <100.00%> (ø)

@juanbono juanbono added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 5dd7642 Jul 3, 2023
@juanbono juanbono deleted the make_statediff_members_public branch July 31, 2023 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all members of StateDiff public
5 participants