This repository was archived by the owner on Jul 22, 2024. It is now read-only.
chore: implement Display instead of ToString
#828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the [standard library documentation](https://doc.rust-lang.org/std/string/trait.ToString.html): > This trait is automatically implemented for any type which implements the `Display` trait. As such, `ToString` shouldn't be implemented directly: `Display` should be implemented instead, and you get the `ToString` implementation for free.
SantiagoPittella
approved these changes
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #828 +/- ##
==========================================
- Coverage 91.76% 91.76% -0.01%
==========================================
Files 54 54
Lines 12871 12870 -1
==========================================
- Hits 11811 11810 -1
Misses 1060 1060
|
juanbono
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
StarknetChainId'sToStringimpl with aDisplayimpl. From the standard library documentation:Checklist