Skip to content

Commit 087bf14

Browse files
authored
Fixes engine resolvers leaking memory (#51450)
1 parent 010b548 commit 087bf14

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/Illuminate/View/ViewServiceProvider.php

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public function registerEngineResolver()
135135
public function registerFileEngine($resolver)
136136
{
137137
$resolver->register('file', function () {
138-
return new FileEngine($this->app['files']);
138+
return new FileEngine(app()->make('files'));
139139
});
140140
}
141141

@@ -148,7 +148,7 @@ public function registerFileEngine($resolver)
148148
public function registerPhpEngine($resolver)
149149
{
150150
$resolver->register('php', function () {
151-
return new PhpEngine($this->app['files']);
151+
return new PhpEngine(app()->make('files'));
152152
});
153153
}
154154

@@ -161,9 +161,14 @@ public function registerPhpEngine($resolver)
161161
public function registerBladeEngine($resolver)
162162
{
163163
$resolver->register('blade', function () {
164-
$compiler = new CompilerEngine($this->app['blade.compiler'], $this->app['files']);
164+
$app = app();
165165

166-
$this->app->terminating(static function () use ($compiler) {
166+
$compiler = new CompilerEngine(
167+
$app->make('blade.compiler'),
168+
$app->make('files'),
169+
);
170+
171+
$app->terminating(static function () use ($compiler) {
167172
$compiler->forgetCompiledOrNotExpired();
168173
});
169174

0 commit comments

Comments
 (0)