[10.x] Test Improvements for Auth tests (#50683)

* Test Improvements for Auth tests

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

---------

Signed-off-by: Mior Muhammad Zaki <[email protected]>

Author: crynobone

tests/Integration/Auth/ApiAuthenticationWithEloquentTest.php

@@ -3,21 +3,18 @@
 namespace Illuminate\Tests\Integration\Auth;
 
 use Illuminate\Database\QueryException;
-use Illuminate\Foundation\Auth\User as FoundationUser;
 use Illuminate\Support\Facades\Route;
 use Illuminate\Support\Str;
 use Orchestra\Testbench\TestCase;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
 
-/**
- * @requires extension pdo_mysql
- */
+#[RequiresPhpExtension('pdo_mysql')]
 class ApiAuthenticationWithEloquentTest extends TestCase
 {
-    protected function getEnvironmentSetUp($app)
+    protected function defineEnvironment($app)
     {
         // Auth configuration
         $app['config']->set('auth.defaults.guard', 'api');
-        $app['config']->set('auth.providers.users.model', User::class);
 
         $app['config']->set('auth.guards.api', [
             'driver' => 'token',
@@ -59,8 +56,3 @@ public function testAuthenticationViaApiWithEloquentUsingWrongDatabaseCredential
         }
     }
 }
-
-class User extends FoundationUser
-{
-    //
-}

tests/Integration/Auth/AuthenticationTest.php

@@ -13,34 +13,50 @@
 use Illuminate\Auth\SessionGuard;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Events\Dispatcher;
+use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Schema;
 use Illuminate\Support\Str;
 use Illuminate\Support\Testing\Fakes\EventFake;
 use Illuminate\Tests\Integration\Auth\Fixtures\AuthenticationTestUser;
 use InvalidArgumentException;
+use Orchestra\Testbench\Attributes\WithMigration;
 use Orchestra\Testbench\TestCase;
 
+#[WithMigration]
 class AuthenticationTest extends TestCase
 {
-    protected function getEnvironmentSetUp($app)
+    use RefreshDatabase;
+
+    protected function defineEnvironment($app)
     {
-        $app['config']->set('auth.providers.users.model', AuthenticationTestUser::class);
+        $app['config']->set([
+            'auth.providers.users.model' => AuthenticationTestUser::class,
+            'hashing.driver' => 'bcrypt',
+        ]);
+    }
 
-        $app['config']->set('hashing', ['driver' => 'bcrypt']);
+    protected function defineRoutes($router)
+    {
+        $router->get('basic', function () {
+            return $this->app['auth']->guard()->basic()
+                ?: $this->app['auth']->user()->toJson();
+        });
+
+        $router->get('basicWithCondition', function () {
+            return $this->app['auth']->guard()->basic('email', ['is_active' => true])
+                ?: $this->app['auth']->user()->toJson();
+        });
     }
 
-    protected function setUp(): void
+    protected function afterRefreshingDatabase()
     {
-        parent::setUp();
-
-        Schema::create('users', function (Blueprint $table) {
-            $table->increments('id');
-            $table->string('email');
-            $table->string('username');
-            $table->string('password');
-            $table->string('remember_token')->default(null)->nullable();
+        Schema::table('users', function (Blueprint $table) {
+            $table->renameColumn('name', 'username');
+        });
+
+        Schema::table('users', function (Blueprint $table) {
             $table->tinyInteger('is_active')->default(0);
         });
 
@@ -50,16 +66,6 @@ protected function setUp(): void
             'password' => bcrypt('password'),
             'is_active' => true,
         ]);
-
-        $this->app->make('router')->get('basic', function () {
-            return $this->app['auth']->guard()->basic()
-                ?: $this->app['auth']->user()->toJson();
-        });
-
-        $this->app->make('router')->get('basicWithCondition', function () {
-            return $this->app['auth']->guard()->basic('email', ['is_active' => true])
-                ?: $this->app['auth']->user()->toJson();
-        });
     }
 
     public function testBasicAuthProtectsRoute()

tests/Integration/Auth/ForgotPasswordTest.php

@@ -3,16 +3,21 @@
 namespace Illuminate\Tests\Integration\Auth;
 
 use Illuminate\Auth\Notifications\ResetPassword;
+use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Notifications\Messages\MailMessage;
 use Illuminate\Support\Facades\Notification;
 use Illuminate\Support\Facades\Password;
 use Illuminate\Support\Str;
 use Illuminate\Tests\Integration\Auth\Fixtures\AuthenticationTestUser;
+use Orchestra\Testbench\Attributes\WithMigration;
 use Orchestra\Testbench\Factories\UserFactory;
 use Orchestra\Testbench\TestCase;
 
+#[WithMigration]
 class ForgotPasswordTest extends TestCase
 {
+    use RefreshDatabase;
+
     protected function tearDown(): void
     {
         ResetPassword::$createUrlCallback = null;
@@ -27,11 +32,6 @@ protected function defineEnvironment($app)
         $app['config']->set('auth.providers.users.model', AuthenticationTestUser::class);
     }
 
-    protected function defineDatabaseMigrations()
-    {
-        $this->loadLaravelMigrations();
-    }
-
     protected function defineRoutes($router)
     {
         $router->get('password/reset/{token}', function ($token) {

tests/Integration/Auth/ForgotPasswordWithoutDefaultRoutesTest.php

@@ -3,16 +3,21 @@
 namespace Illuminate\Tests\Integration\Auth;
 
 use Illuminate\Auth\Notifications\ResetPassword;
+use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Notifications\Messages\MailMessage;
 use Illuminate\Support\Facades\Notification;
 use Illuminate\Support\Facades\Password;
 use Illuminate\Support\Str;
 use Illuminate\Tests\Integration\Auth\Fixtures\AuthenticationTestUser;
+use Orchestra\Testbench\Attributes\WithMigration;
 use Orchestra\Testbench\Factories\UserFactory;
 use Orchestra\Testbench\TestCase;
 
+#[WithMigration]
 class ForgotPasswordWithoutDefaultRoutesTest extends TestCase
 {
+    use RefreshDatabase;
+
     protected function tearDown(): void
     {
         ResetPassword::$createUrlCallback = null;
@@ -27,11 +32,6 @@ protected function defineEnvironment($app)
         $app['config']->set('auth.providers.users.model', AuthenticationTestUser::class);
     }
 
-    protected function defineDatabaseMigrations()
-    {
-        $this->loadLaravelMigrations();
-    }
-
     protected function defineRoutes($router)
     {
         $router->get('custom/password/reset/{token}', function ($token) {