Skip to content

Commit b6a5179

Browse files
authored
Fix: shouldConvertToBoolean when parameter uses dot notation (#53048)
1 parent bc02689 commit b6a5179

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/Illuminate/Validation/Concerns/ValidatesAttributes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2259,7 +2259,7 @@ public function parseDependentRuleParameters($parameters)
22592259
*/
22602260
protected function shouldConvertToBoolean($parameter)
22612261
{
2262-
return in_array('boolean', Arr::get($this->rules, $parameter, []));
2262+
return in_array('boolean', $this->rules[$parameter] ?? []);
22632263
}
22642264

22652265
/**

tests/Validation/ValidationValidatorTest.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1696,6 +1696,14 @@ public function testRequiredIf()
16961696
$this->assertTrue($v->fails());
16971697
$this->assertCount(1, $v->messages());
16981698
$this->assertSame('The baz field is required when foo is empty.', $v->messages()->first('baz'));
1699+
1700+
$trans = $this->getIlluminateArrayTranslator();
1701+
$v = new Validator(
1702+
$trans,
1703+
['foo' => 'bar', 'customfield' => ['1' => 'taylor']],
1704+
['customfield' => ['nullable', 'array'], 'foo' => 'required_if:customfield.1,taylor']
1705+
);
1706+
$this->assertTrue($v->passes());
16991707
}
17001708

17011709
public function testRequiredIfArrayToStringConversationErrorException()

0 commit comments

Comments
 (0)