[10.x] Test Improvements for Console tests (#50685)

Signed-off-by: Mior Muhammad Zaki <[email protected]>

Author: crynobone

tests/Integration/Console/CommandEventsTest.php

@@ -12,6 +12,7 @@
 use Illuminate\Support\Str;
 use Orchestra\Testbench\Foundation\Application as Testbench;
 use Orchestra\Testbench\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class CommandEventsTest extends TestCase
 {
@@ -48,9 +49,7 @@ protected function setUp(): void
         parent::setUp();
     }
 
-    /**
-     * @dataProvider foregroundCommandEventsProvider
-     */
+    #[DataProvider('foregroundCommandEventsProvider')]
     public function testCommandEventsReceiveParsedInput($callback)
     {
         $this->app[ConsoleKernel::class]->registerCommand(new CommandEventsTestCommand);

tests/Integration/Console/CommandSchedulingTest.php

@@ -6,6 +6,7 @@
 use Illuminate\Filesystem\Filesystem;
 use Illuminate\Support\Str;
 use Orchestra\Testbench\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class CommandSchedulingTest extends TestCase
 {
@@ -62,9 +63,7 @@ protected function tearDown(): void
         parent::tearDown();
     }
 
-    /**
-     * @dataProvider executionProvider
-     */
+    #[DataProvider('executionProvider')]
     public function testExecutionOrder($background, $expected)
     {
         $schedule = $this->app->make(Schedule::class);

tests/Integration/Console/GeneratorCommandTest.php

@@ -3,12 +3,11 @@
 namespace Illuminate\Tests\Integration\Console;
 
 use Orchestra\Testbench\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class GeneratorCommandTest extends TestCase
 {
-    /**
-     * @dataProvider reservedNamesDataProvider
-     */
+    #[DataProvider('reservedNamesDataProvider')]
     public function testItCannotGenerateClassUsingReservedName($given)
     {
         $this->artisan('make:command', ['name' => $given])

tests/Integration/Console/Scheduling/CallbackEventTest.php

@@ -10,13 +10,6 @@
 
 class CallbackEventTest extends TestCase
 {
-    protected function tearDown(): void
-    {
-        parent::tearDown();
-
-        m::close();
-    }
-
     public function testDefaultResultIsSuccess()
     {
         $success = null;

tests/Integration/Console/Scheduling/EventPingTest.php

@@ -16,13 +16,6 @@
 
 class EventPingTest extends TestCase
 {
-    protected function tearDown(): void
-    {
-        parent::tearDown();
-
-        m::close();
-    }
-
     public function testPingRescuesTransferExceptions()
     {
         $this->spy(ExceptionHandler::class)

tests/Integration/Console/Scheduling/SubMinuteSchedulingTest.php

@@ -7,6 +7,7 @@
 use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Sleep;
 use Orchestra\Testbench\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class SubMinuteSchedulingTest extends TestCase
 {
@@ -45,7 +46,7 @@ public function test_it_doesnt_wait_for_sub_minute_events_when_none_are_schedule
         Sleep::assertNeverSlept();
     }
 
-    /** @dataProvider frequencyProvider */
+    #[DataProvider('frequencyProvider')]
     public function test_it_runs_sub_minute_callbacks($frequency, $expectedRuns)
     {
         $runs = 0;

tests/Integration/Cookie/CookieTest.php

@@ -14,13 +14,6 @@
 
 class CookieTest extends TestCase
 {
-    protected function tearDown(): void
-    {
-        parent::tearDown();
-
-        Carbon::setTestNow(null);
-    }
-
     public function test_cookie_is_sent_back_with_proper_expire_time_when_should_expire_on_close()
     {
         $this->app['config']->set('session.expire_on_close', true);